summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2021-11-16 10:32:09 +0100
committerZbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>2021-11-16 12:26:23 +0100
commitae568b15ec4abde3c71f3d1914832c4cc77672c9 (patch)
tree1854948811972de7b1a91ff0299ffbee05df5ed9
parent6fdabc83c227987c56de9bd80368b148fb93fa6f (diff)
downloadsystemd-ae568b15ec4abde3c71f3d1914832c4cc77672c9.tar.gz
basic/generate-fs-switch-case: inline comments
Let's keep the comments together with the lines they describe, this is easier to read and probably more maintainable in the long run. Also, () → {} for idiomaticity.
-rwxr-xr-xsrc/basic/generate-filesystem-switch-case.py40
1 files changed, 15 insertions, 25 deletions
diff --git a/src/basic/generate-filesystem-switch-case.py b/src/basic/generate-filesystem-switch-case.py
index 73b1d65657..bbd09228e1 100755
--- a/src/basic/generate-filesystem-switch-case.py
+++ b/src/basic/generate-filesystem-switch-case.py
@@ -7,32 +7,22 @@ import sys
def filter_fsname(name):
# File system magics are sometimes not unique, because file systems got new
# revisions or got renamed. Let's prefer newer over older here, and thus
- # ignore the old names. Specifically:
- #
- # → cgroupfs took over the magic of cpuset
- # → devtmpfs is not a file system of its own, but just a "named superblock" of tmpfs
- # → ext4 is the newest revision of ext2 + ext3
- # → fuseblk is closely related to fuse, so close that they share a single magic, but the latter is more common
- # → gfs2 is the newest revision of gfs
- # → vfat is the newest revision of msdos
- # → ncpfs (not ncp) was the last name of the netware `file_system_type` name before it was removed in 2018
- # → nfs4 is the newest revision of nfs
- # → orangefs is the new name of pvfs2
- # → smb3 is an alias for cifs
-
- return name in (
- "cpuset",
- "devtmpfs",
- "ext2",
+ # ignore the old names.
+
+ return name in {
+ "cpuset", # magic taken over by cgroupfs
+ "devtmpfs", # not a file system of its own, but just a "named superblock" of tmpfs
+ "ext2", # ext4 is the newest revision of ext2 + ext3
"ext3",
- "fuseblk",
- "gfs",
- "msdos",
- "ncp",
- "nfs",
- "pvfs2",
- "smb3",
- )
+ "fuseblk", # closely related to fuse; they share a single magic, but the latter is more common
+ "gfs", # magic taken over by gfs2
+ "msdos", # vfat is the newest revision of msdos
+ "ncp", # ncpfs (not ncp) was the last name of the netware `file_system_type`
+ # name before it was removed in 2018
+ "nfs", # nfs4 is the newest revision of nfs
+ "pvfs2", # orangefs is the new name of pvfs2
+ "smb3", # smb3 is an alias for cifs
+ }
gperf_file = sys.argv[1]