diff options
| author | Lennart Poettering <lennart@poettering.net> | 2021-03-24 21:21:08 +0100 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-03-25 10:43:23 +0100 |
| commit | 9b564bbca5fcfb251b7990c8642c82846d09338b (patch) | |
| tree | c9157db06393f37df21df763b99352f701c40bd7 | |
| parent | 390e67305d003b905cc8b150f5fe075c73bbbc99 (diff) | |
| download | systemd-9b564bbca5fcfb251b7990c8642c82846d09338b.tar.gz | |
resolved: upgrade log level to LOG_NOTICE if we switch to fallback server (or back)
This is inspired by a recent thread on fedora-devel: it's noteworthy
when we switch to the fallback servers, since it might (or might not)
indicate some configuration problem.
Fixes: #18788
| -rw-r--r-- | src/resolve/resolved-dns-server.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/resolve/resolved-dns-server.c b/src/resolve/resolved-dns-server.c index 8248156354..073489acae 100644 --- a/src/resolve/resolved-dns-server.c +++ b/src/resolve/resolved-dns-server.c @@ -867,10 +867,11 @@ DnsServer *manager_set_dns_server(Manager *m, DnsServer *s) { if (m->current_dns_server == s) return s; + /* Let's log about the server switch, at debug level. Except if we switch from a non-fallback server + * to a fallback server or back, since that is noteworthy and possibly a configuration issue */ if (s) - log_debug("Switching to %s DNS server %s.", - dns_server_type_to_string(s->type), - strna(dns_server_string_full(s))); + log_full((s->type == DNS_SERVER_FALLBACK) != (m->current_dns_server && m->current_dns_server->type == DNS_SERVER_FALLBACK) ? LOG_NOTICE : LOG_DEBUG, + "Switching to %s DNS server %s.", dns_server_type_to_string(s->type), strna(dns_server_string_full(s))); dns_server_unref(m->current_dns_server); m->current_dns_server = dns_server_ref(s); |