summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEvgeny Vereshchagin <evvers@ya.ru>2018-10-26 09:19:09 +0000
committerFrantisek Sumsal <frantisek@sumsal.cz>2019-02-19 13:27:54 +0100
commitc9fdcd0693ac63bc4b7326e248854617d9573bd6 (patch)
tree3950068ab093971c46c930b277fd70c0218b8a6b
parent5adeea95a7310d97b98821322b51794a46199417 (diff)
downloadsystemd-c9fdcd0693ac63bc4b7326e248854617d9573bd6.tar.gz
lgtm: add a custom query for catching the use of fgets
As everybody knows, nodoby really reads CODING_STYLE (especially the last paragraph :-)) so let's utilize LGTM to help us catch the use of fgets. (cherry picked from commit f86c1da28340f2a2afd34d72c9f416a2a94219a8)
-rw-r--r--.lgtm/cpp-queries/fgets.ql23
1 files changed, 23 insertions, 0 deletions
diff --git a/.lgtm/cpp-queries/fgets.ql b/.lgtm/cpp-queries/fgets.ql
new file mode 100644
index 0000000000..82de8c4482
--- /dev/null
+++ b/.lgtm/cpp-queries/fgets.ql
@@ -0,0 +1,23 @@
+/**
+ * @name Use of fgets()
+ * @description fgets() is dangerous to call. Use read_line() instead.
+ * @kind problem
+ * @problem.severity error
+ * @precision high
+ * @id cpp/fgets
+ * @tags reliability
+ * security
+ */
+import cpp
+
+
+predicate dangerousFunction(Function function) {
+ exists (string name | name = function.getQualifiedName() |
+ name = "fgets")
+}
+
+
+from FunctionCall call, Function target
+where call.getTarget() = target
+ and dangerousFunction(target)
+select call, target.getQualifiedName() + " is potentially dangerous"