summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2020-04-29 16:24:41 +0200
committerLennart Poettering <lennart@poettering.net>2020-04-29 16:32:46 +0200
commit2ffee2c9b059e0988662fb14ab1b19450258fdb0 (patch)
treebb7bb69a5f07c035caa102d9105ef2d791ce567e
parent94600eeb29ac889513505611ece30fea8586313e (diff)
downloadsystemd-2ffee2c9b059e0988662fb14ab1b19450258fdb0.tar.gz
home: mark various bus messages we write user records to as sensitive
let's make sure that when we append potentially sensitive data to a bus message we set the sensitive flag on the message object.
-rw-r--r--src/home/home-util.c2
-rw-r--r--src/home/homectl.c4
2 files changed, 6 insertions, 0 deletions
diff --git a/src/home/home-util.c b/src/home/home-util.c
index 69ab645484..51406fd234 100644
--- a/src/home/home-util.c
+++ b/src/home/home-util.c
@@ -124,6 +124,8 @@ int bus_message_append_secret(sd_bus_message *m, UserRecord *secret) {
if (r < 0)
return r;
+ (void) sd_bus_message_sensitive(m);
+
return sd_bus_message_append(m, "s", formatted);
}
diff --git a/src/home/homectl.c b/src/home/homectl.c
index 9b614325a5..c98bf8b540 100644
--- a/src/home/homectl.c
+++ b/src/home/homectl.c
@@ -1435,6 +1435,8 @@ static int create_home(int argc, char *argv[], void *userdata) {
if (r < 0)
return bus_log_create_error(r);
+ (void) sd_bus_message_sensitive(m);
+
r = sd_bus_message_append(m, "s", formatted);
if (r < 0)
return bus_log_create_error(r);
@@ -1637,6 +1639,8 @@ static int update_home(int argc, char *argv[], void *userdata) {
if (r < 0)
return r;
+ (void) sd_bus_message_sensitive(m);
+
r = sd_bus_message_append(m, "s", formatted);
if (r < 0)
return bus_log_create_error(r);