diff options
| author | Lennart Poettering <lennart@poettering.net> | 2020-05-28 23:34:24 +0200 |
|---|---|---|
| committer | Lennart Poettering <lennart@poettering.net> | 2020-05-28 23:38:38 +0200 |
| commit | 6527b019fc1a280917f366887722fa7c036d6e04 (patch) | |
| tree | cda3bb3d303c9552eb9a379ea0410a989f007451 | |
| parent | 871dc8d644eef7542a5330f84c25b1db2617317c (diff) | |
| download | systemd-6527b019fc1a280917f366887722fa7c036d6e04.tar.gz | |
xdg-autostart: fix two coverity found issues
Fixes: CID#1429003
Fixes: CID#1429004
| -rw-r--r-- | src/fuzz/fuzz-xdg-desktop.c | 3 | ||||
| -rw-r--r-- | src/xdg-autostart-generator/xdg-autostart-service.c | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/src/fuzz/fuzz-xdg-desktop.c b/src/fuzz/fuzz-xdg-desktop.c index 8c6472bee5..f8a1b5b28b 100644 --- a/src/fuzz/fuzz-xdg-desktop.c +++ b/src/fuzz/fuzz-xdg-desktop.c @@ -30,8 +30,7 @@ int LLVMFuzzerTestOneInput(const uint8_t *data, size_t size) { assert_se(service = xdg_autostart_service_parse_desktop(name)); assert_se(service->name = strdup("fuzz-xdg-desktop.service")); - if (service) - (void) xdg_autostart_service_generate_unit(service, tmpdir); + (void) xdg_autostart_service_generate_unit(service, tmpdir); return 0; } diff --git a/src/xdg-autostart-generator/xdg-autostart-service.c b/src/xdg-autostart-generator/xdg-autostart-service.c index 9ff80c5bb0..c99b6cc883 100644 --- a/src/xdg-autostart-generator/xdg-autostart-service.c +++ b/src/xdg-autostart-generator/xdg-autostart-service.c @@ -73,7 +73,6 @@ static int xdg_config_parse_bool( void *userdata) { bool *b = data; - const char *value; assert(filename); assert(lvalue); @@ -85,7 +84,7 @@ static int xdg_config_parse_bool( else if (streq(rvalue, "false")) *b = false; else - return log_syntax(unit, LOG_ERR, filename, line, SYNTHETIC_ERRNO(EINVAL), "Invalid value for boolean: %s", value); + return log_syntax(unit, LOG_ERR, filename, line, SYNTHETIC_ERRNO(EINVAL), "Invalid value for boolean: %s", rvalue); return 0; } |