summaryrefslogtreecommitdiff
path: root/CODING_STYLE
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2015-02-11 18:50:38 +0100
committerLennart Poettering <lennart@poettering.net>2015-02-11 18:50:38 +0100
commiteef46c372f64f40dd75415b2c504c73138719c8d (patch)
treed13d0d3b02025f837ccc360e2e6adc259d61ec9a /CODING_STYLE
parente89fe484df6b94fcd775b923327b54eaf0a116e2 (diff)
downloadsystemd-eef46c372f64f40dd75415b2c504c73138719c8d.tar.gz
tree-wide: whenever we include libgen.h, immediately undefine basename()
Also, document in adjacent comments and in CODING_STYLE why we do that.
Diffstat (limited to 'CODING_STYLE')
-rw-r--r--CODING_STYLE6
1 files changed, 6 insertions, 0 deletions
diff --git a/CODING_STYLE b/CODING_STYLE
index 1d1d970492..5574013487 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -202,3 +202,9 @@
b) socket() and socketpair() must get SOCK_CLOEXEC passed
c) recvmsg() must get MSG_CMSG_CLOEXEC set
d) F_DUPFD_CLOEXEC should be used instead of F_DUPFD, and so on
+
+- We never use the XDG version of basename(). glibc defines it in
+ libgen.h. The only reason to include that file is because dirname()
+ is needed. Everytime you need that please immediately undefine
+ basename(), and add a comment about it, so that no code ever ends up
+ using the XDG version!