summaryrefslogtreecommitdiff
path: root/CODING_STYLE
diff options
context:
space:
mode:
authorLennart Poettering <lennart@poettering.net>2015-03-10 17:39:42 +0100
committerLennart Poettering <lennart@poettering.net>2015-03-10 17:39:42 +0100
commit918315e457ca36cab94ff3b6060e143968c99ace (patch)
treededac71d80ce134f262ec235f1df3616e833c75f /CODING_STYLE
parent52fa7a3af1322aa716e5afc08b60ff2e9e13c022 (diff)
downloadsystemd-918315e457ca36cab94ff3b6060e143968c99ace.tar.gz
CODING_STYLE: mention casting of function invocations to (void)
Diffstat (limited to 'CODING_STYLE')
-rw-r--r--CODING_STYLE14
1 files changed, 14 insertions, 0 deletions
diff --git a/CODING_STYLE b/CODING_STYLE
index 0340ff0fa3..b687e729f4 100644
--- a/CODING_STYLE
+++ b/CODING_STYLE
@@ -212,3 +212,17 @@
- Use the bool type for booleans, not integers. One exception: in public
headers (i.e those in src/systemd/sd-*.h) use integers after all, as "bool"
is C99 and in our public APIs we try to stick to C89 (with a few extension).
+
+- When you invoke certain calls like unlink(), or mkdir_p() and you
+ know it is safe to ignore the error it might return (because a later
+ call would detect the failure anyway, or because the error is in an
+ error path and you thus couldn't do anything about it anyway), then
+ make this clear by casting the invocation explicitly to (void). Code
+ checks like Coverity understand that, and will not complain about
+ ignored error codes. Hence, please use this:
+
+ (void) unlink("/foo/bar/baz");
+
+ instead of just this:
+
+ unlink("/foo/bar/baz");