diff options
| author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2016-09-27 12:40:54 +0200 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2016-09-28 23:50:29 +0200 |
| commit | 73a99163a721d9e96bf7006ecbfb1aefce228c99 (patch) | |
| tree | 4f2f223326259394c5550febfe5662f419f1881c /TODO | |
| parent | 6e9ef6038f3971ae42657b98d952ed4c1318b4d7 (diff) | |
| download | systemd-73a99163a721d9e96bf7006ecbfb1aefce228c99.tar.gz | |
coredump,catalog: give better notice when a core file is truncated
coredump had code to check if copy_bytes() hit the max_bytes limit,
and refuse further processing in that case.
But in 84ee0960443, the return convention for copy_bytes() was changed
from -EFBIG to 1 for the case when the limit is hit, so the condition
check in coredump couldn't ever trigger.
But it seems that *do* want to process such truncated cores [1].
So change the code to detect truncation properly, but instead of
returning an error, give a nice log entry.
[1] https://github.com/systemd/systemd/issues/3883#issuecomment-239106337
Should fix (or at least alleviate) #3883.
Diffstat (limited to 'TODO')
| -rw-r--r-- | TODO | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -670,6 +670,7 @@ Features: * coredump: - save coredump in Windows/Mozilla minidump format + - when truncating coredumps, also log the full size that the process had, and make a metadata field so we can report truncated coredumps * support crash reporting operation modes (https://live.gnome.org/GnomeOS/Design/Whiteboards/ProblemReporting) |