diff options
author | Frantisek Sumsal <frantisek@sumsal.cz> | 2020-10-09 14:59:44 +0200 |
---|---|---|
committer | Frantisek Sumsal <frantisek@sumsal.cz> | 2020-10-09 15:02:23 +0200 |
commit | d7a0f1f4f9910a1a2d290e31b2ba8cfa7126fbdd (patch) | |
tree | f519b20cb0835f71bd553abeca761882cad3299b /src/analyze | |
parent | 44e66de0f25e65d5bd8b2f7f848e0fc7b98199ed (diff) | |
download | systemd-d7a0f1f4f9910a1a2d290e31b2ba8cfa7126fbdd.tar.gz |
tree-wide: assorted coccinelle fixes
Diffstat (limited to 'src/analyze')
-rw-r--r-- | src/analyze/analyze-security.c | 8 | ||||
-rw-r--r-- | src/analyze/analyze.c | 3 |
2 files changed, 5 insertions, 6 deletions
diff --git a/src/analyze/analyze-security.c b/src/analyze/analyze-security.c index 16ab4f893e..9c1d63030d 100644 --- a/src/analyze/analyze-security.c +++ b/src/analyze/analyze-security.c @@ -2185,10 +2185,10 @@ int analyze_security(sd_bus *bus, char **units, AnalyzeSecurityFlags flags) { if (r < 0) return log_error_errno(r, "Failed to mangle unit name '%s': %m", *i); - if (!endswith(mangled, ".service")) { - log_error("Unit %s is not a service unit, refusing.", *i); - return -EINVAL; - } + if (!endswith(mangled, ".service")) + return log_error_errno(SYNTHETIC_ERRNO(EINVAL), + "Unit %s is not a service unit, refusing.", + *i); if (unit_name_is_valid(mangled, UNIT_NAME_TEMPLATE)) { r = unit_name_replace_instance(mangled, "test-instance", &instance); diff --git a/src/analyze/analyze.c b/src/analyze/analyze.c index a9e4b37573..591ba6d33c 100644 --- a/src/analyze/analyze.c +++ b/src/analyze/analyze.c @@ -1248,8 +1248,7 @@ static int expand_patterns(sd_bus *bus, char **patterns, char ***ret) { } } - *ret = expanded_patterns; - expanded_patterns = NULL; /* do not free */ + *ret = TAKE_PTR(expanded_patterns); /* do not free */ return 0; } |