diff options
| author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2018-06-11 16:02:03 +0200 |
|---|---|---|
| committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2018-06-13 10:52:40 +0200 |
| commit | 5d904a6aaaceae7fe2f11d6b848b0dd45e3fd1c4 (patch) | |
| tree | b030bb7f74e44a28676f91d05faae95ed0c80a94 /src/basic | |
| parent | 37e744e8661c3edd8b8efa723a3d3c71f73ef542 (diff) | |
| download | systemd-5d904a6aaaceae7fe2f11d6b848b0dd45e3fd1c4.tar.gz | |
tree-wide: drop !! casts to booleans
They are not needed, because anything that is non-zero is converted
to true.
C11:
> 6.3.1.2: When any scalar value is converted to _Bool, the result is 0 if the
> value compares equal to 0; otherwise, the result is 1.
https://stackoverflow.com/questions/31551888/casting-int-to-bool-in-c-c
Diffstat (limited to 'src/basic')
| -rw-r--r-- | src/basic/btrfs-util.c | 2 | ||||
| -rw-r--r-- | src/basic/format-table.c | 2 | ||||
| -rw-r--r-- | src/basic/verbs.c | 2 | ||||
| -rw-r--r-- | src/basic/virt.c | 2 |
4 files changed, 4 insertions, 4 deletions
diff --git a/src/basic/btrfs-util.c b/src/basic/btrfs-util.c index 32a022f7ce..b325090ed9 100644 --- a/src/basic/btrfs-util.c +++ b/src/basic/btrfs-util.c @@ -500,7 +500,7 @@ int btrfs_subvol_get_info_fd(int fd, uint64_t subvol_id, BtrfsSubvolInfo *ret) { (usec_t) le32toh(ri->otime.nsec) / NSEC_PER_USEC; ret->subvol_id = subvol_id; - ret->read_only = !!(le64toh(ri->flags) & BTRFS_ROOT_SUBVOL_RDONLY); + ret->read_only = le64toh(ri->flags) & BTRFS_ROOT_SUBVOL_RDONLY; assert_cc(sizeof(ri->uuid) == sizeof(ret->uuid)); memcpy(&ret->uuid, ri->uuid, sizeof(ret->uuid)); diff --git a/src/basic/format-table.c b/src/basic/format-table.c index ad89556ee2..94e796d1ca 100644 --- a/src/basic/format-table.c +++ b/src/basic/format-table.c @@ -572,7 +572,7 @@ int table_add_many_internal(Table *t, TableDataType first_type, ...) { break; case TABLE_BOOLEAN: - buffer.b = !!va_arg(ap, int); + buffer.b = va_arg(ap, int); data = &buffer.b; break; diff --git a/src/basic/verbs.c b/src/basic/verbs.c index 58076ac07c..057e35dcd0 100644 --- a/src/basic/verbs.c +++ b/src/basic/verbs.c @@ -81,7 +81,7 @@ int dispatch_verb(int argc, char *argv[], const Verb verbs[], void *userdata) { if (name) found = streq(name, verbs[i].verb); else - found = !!(verbs[i].flags & VERB_DEFAULT); + found = verbs[i].flags & VERB_DEFAULT; if (found) { verb = &verbs[i]; diff --git a/src/basic/virt.c b/src/basic/virt.c index 9da5feca6c..0ebccd4ebb 100644 --- a/src/basic/virt.c +++ b/src/basic/virt.c @@ -56,7 +56,7 @@ static int detect_vm_cpuid(void) { if (__get_cpuid(1, &eax, &ebx, &ecx, &edx) == 0) return VIRTUALIZATION_NONE; - hypervisor = !!(ecx & 0x80000000U); + hypervisor = ecx & 0x80000000U; if (hypervisor) { union { |