diff options
author | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-07-27 12:27:28 +0200 |
---|---|---|
committer | Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl> | 2021-08-03 10:05:10 +0200 |
commit | 04499a70fbff3f6b798028473f5c9234a53eaa2d (patch) | |
tree | ec7a851e163ee20ba5211c16a86f1c251543e0a7 /src/network/networkd-queue.c | |
parent | c7cfde640d2b32ff1eb893d1fcd291c25cd421e7 (diff) | |
download | systemd-04499a70fbff3f6b798028473f5c9234a53eaa2d.tar.gz |
Drop the text argument from assert_not_reached()
In general we almost never hit those asserts in production code, so users see
them very rarely, if ever. But either way, we just need something that users
can pass to the developers.
We have quite a few of those asserts, and some have fairly nice messages, but
many are like "WTF?" or "???" or "unexpected something". The error that is
printed includes the file location, and function name. In almost all functions
there's at most one assert, so the function name alone is enough to identify
the failure for a developer. So we don't get much extra from the message, and
we might just as well drop them.
Dropping them makes our code a tiny bit smaller, and most importantly, improves
development experience by making it easy to insert such an assert in the code
without thinking how to phrase the argument.
Diffstat (limited to 'src/network/networkd-queue.c')
-rw-r--r-- | src/network/networkd-queue.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/network/networkd-queue.c b/src/network/networkd-queue.c index 5ef4acf5ac..db682d434b 100644 --- a/src/network/networkd-queue.c +++ b/src/network/networkd-queue.c @@ -53,7 +53,7 @@ static void request_free_object(RequestType type, void *object) { case REQUEST_TYPE_UP_DOWN: break; default: - assert_not_reached("invalid request type."); + assert_not_reached(); } } @@ -134,7 +134,7 @@ static void request_hash_func(const Request *req, struct siphash *state) { case REQUEST_TYPE_UP_DOWN: break; default: - assert_not_reached("invalid request type."); + assert_not_reached(); } } @@ -181,7 +181,7 @@ static int request_compare_func(const struct Request *a, const struct Request *b case REQUEST_TYPE_UP_DOWN: return 0; default: - assert_not_reached("invalid request type."); + assert_not_reached(); } } |