summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Add mkosi.output/ to .gitignoreZbigniew Jędrzejewski-Szmek2017-11-291-0/+1
| | | | | It's not something that would ever be checked in, and mkosi along with systemd, so this directory is likely to appear.
* mkosi: do not build man pagesZbigniew Jędrzejewski-Szmek2017-11-291-1/+1
|
* Merge pull request #7492 from keszybz/coverity-fixesYu Watanabe2017-11-2933-205/+142
|\ | | | | A few more cleanups based on coverity and valgrind
| * udev/collect: use _cleanup_ in one more placeZbigniew Jędrzejewski-Szmek2017-11-281-7/+3
| | | | | | | | This doesn't make the code pretty, but it at least makes it a tiny bit shorter.
| * udev/collect: remove dead conditionalZbigniew Jędrzejewski-Szmek2017-11-281-2/+0
| | | | | | | | | | Coverity rightly says that 'word' is assigned to 'ptr', and 'word' was assigned from 'ptr' (yikes) right after a non-null check.
| * journal: avoid undefined behaviour in float division by 0.0Zbigniew Jędrzejewski-Szmek2017-11-281-1/+1
| | | | | | | | | | | | Coverity says that's undefined. I'm pretty sure we always would get a nan, but let's avoid (formally) undefined behaviour since that can cause compilers to do strange things.
| * networkd: fix memleak of RulesZbigniew Jędrzejewski-Szmek2017-11-282-6/+4
| | | | | | | | This was the issue mentioned in 93f9da6e0a.
| * journal: use new helpers with journal_file_closeZbigniew Jędrzejewski-Szmek2017-11-284-26/+4
| | | | | | | | journal_file_close_set() is not necessary anymore.
| * journal-remote: add helper function and use hashmap_free_with_destructorZbigniew Jędrzejewski-Szmek2017-11-281-9/+8
| |
| * cryptsetup-generator: add helper function and use hashmap_free_with_destructorZbigniew Jędrzejewski-Szmek2017-11-281-13/+7
| |
| * coredump: fix typo and use hashmap_free_with_destructorZbigniew Jędrzejewski-Szmek2017-11-281-9/+4
| |
| * machine-image: convert image_hashmap_free() to an static inline helperZbigniew Jędrzejewski-Szmek2017-11-282-10/+3
| |
| * Add set/hashmap helpers for non-trivial freeing and use where straighforwardZbigniew Jędrzejewski-Szmek2017-11-2819-114/+106
| | | | | | | | | | | | A macro is needed because otherwise we couldn't ensure type safety. Some simple tests are included. No functional change intended.
| * Use hashmap_free_free where appropriateZbigniew Jędrzejewski-Szmek2017-11-282-8/+2
| |
* | Merge pull request #7490 from yuwata/test-basicZbigniew Jędrzejewski-Szmek2017-11-2810-54/+160
|\ \ | |/ |/| add more tests for basic functions
| * test-cap-list: add more tests about capability_set_{from,to}_string()Yu Watanabe2017-11-281-9/+59
| |
| * test: move tests about cap_list_cap() from test-cap-list to test-capabilityYu Watanabe2017-11-282-36/+39
| |
| * cap-list: check range of numeric valueYu Watanabe2017-11-281-2/+6
| |
| * test-bitmap: add tests for bitmap_copy()Yu Watanabe2017-11-281-0/+11
| |
| * test-architecture: add more testsYu Watanabe2017-11-281-2/+16
| |
| * test-alloc-util: add tests for memdup_suffix0() and greedy_realloc()Yu Watanabe2017-11-281-5/+27
| |
| * tests: add tests for empty stringYu Watanabe2017-11-282-0/+2
| |
| * alloc-util: coding style fixYu Watanabe2017-11-282-2/+2
| |
* | networkd: Add comment for setting_mtu #7460 (#7489)Susant Sahani2017-11-281-0/+3
| | | | | | Follow up #7460
* | Merge pull request #7486 from keszybz/coverity-fixesLennart Poettering2017-11-2819-130/+274
|\ \ | |/ |/| Fixes for issues spotted by coverity (and some cleanups)
| * pid1: improve syntax in error messageZbigniew Jędrzejewski-Szmek2017-11-281-2/+2
| |
| * pid1: clarify that min_max is always initializedZbigniew Jędrzejewski-Szmek2017-11-281-1/+1
| | | | | | | | | | read_one_line_file() always returns <= 0, so the code was OK, but let's write the check a bit differently to make it obvious that min_max is always set.
| * test-hostname-util: add assert_se's to make coverity happyZbigniew Jędrzejewski-Szmek2017-11-281-5/+5
| |
| * test-process-util: add (void) cast to make coverity happyZbigniew Jędrzejewski-Szmek2017-11-281-1/+1
| | | | | | | | | | The intent is for the call to succeed only when privileged, so make that clear.
| * test-fd-util: add assert_se to make coverity happyZbigniew Jędrzejewski-Szmek2017-11-281-1/+1
| |
| * udevadm-monitor: add some assert_se's to make coverity happyZbigniew Jędrzejewski-Szmek2017-11-281-6/+6
| | | | | | | | We do that elsewhere and it's nice to be consistent.
| * core/umount: use _cleanup_ in one more placeZbigniew Jędrzejewski-Szmek2017-11-281-10/+4
| |
| * sd-resolve: check that name fits in the specified packet lengthZbigniew Jędrzejewski-Szmek2017-11-281-17/+29
| | | | | | | | Coverity complained that we didn't check if the data is long enough.
| * shim: fix logically dead codeZbigniew Jędrzejewski-Szmek2017-11-281-9/+4
| | | | | | | | | | | | The alternate verification path could never be taken. Found by coverity.
| * networkd: remove dead codeZbigniew Jędrzejewski-Szmek2017-11-281-3/+0
| | | | | | | | Found by coverity.
| * test-ndisc-ra: add assert_se() to make coverity happyZbigniew Jędrzejewski-Szmek2017-11-281-1/+1
| |
| * boot/shim: fix char ** vs char * mismatchZbigniew Jędrzejewski-Szmek2017-11-281-2/+2
| | | | | | | | | | | | This code cannot have ever worked ;( Found by coverity, obvious when the type is not obfuscated to void*.
| * boot/efi: fix NULL dereferenceZbigniew Jędrzejewski-Szmek2017-11-281-7/+7
| | | | | | | | | | | | | | | | | | | | | | | | The comment above makes the intent of the code pretty clear: "use security2_protocol == NULL as indicator". So revert the condition in the check and fix the logic in the comment while at it. The question is how this could have ever worked: if BS->LocateProtocol (which is supposedly optional) ever failed, we'd crash here. Strange. Found by coverity.
| * dissect-image: simplify check for passphrase presenceZbigniew Jędrzejewski-Szmek2017-11-281-3/+3
| | | | | | | | | | | | m->encrypted is set when fstype=="crypto_LUKS", but this is not obvious when reading decrypt_partition(). Just check if passphrase is set before using it.
| * networkd: fix reversed argumentsZbigniew Jędrzejewski-Szmek2017-11-283-5/+3
| | | | | | | | | | | | Found by coverity. Also drop unused return value while at it.
| * networkd: plug some memleaks in rule serialization/deserializationZbigniew Jędrzejewski-Szmek2017-11-282-4/+7
| | | | | | | | | | | | | | This fixes the (mostly theoretical, since we're only parsing data that we write ourselves) memleak when iif or oif is deserialized multiple times. Unfortunately it does not fix the memleak when rule is freed, but that'll require a bigger effort.
| * networkd: fix serialization of {Incoming,Outgoing}InterfaceZbigniew Jędrzejewski-Szmek2017-11-282-4/+25
| | | | | | | | | | | | | | | | Let's just say that the code wasn't fully functional ;( Since we only had the parser for serialization, and not the writer, we are free to change the format. So while at it, let's use shorter names in the serialization format that match the surrounding style.
| * Add test-routing-policy-ruleZbigniew Jędrzejewski-Szmek2017-11-282-0/+99
| |
| * test-network: use automatic cleanupZbigniew Jędrzejewski-Szmek2017-11-281-12/+6
| |
| * networkd: parse the rvalue, not the option nameZbigniew Jędrzejewski-Szmek2017-11-281-1/+1
| | | | | | | | :(
| * networkd: move rule loading to a separate functionZbigniew Jędrzejewski-Szmek2017-11-283-54/+69
| | | | | | | | No functional change.
| * networkd: unbork rule serializationZbigniew Jędrzejewski-Szmek2017-11-272-11/+27
| | | | | | | | | | | | | | We'd write something like RULE=from=250.250.240.0/24 to=(null)/0 tos=0 fwmark=0/0 table=12 RULE=from=250.250.250.0/24 to=(null)/0 tos=0 fwmark=0/0 table=11
* | Merge pull request #7398 from keszybz/udev-listLennart Poettering2017-11-282-28/+20
|\ \ | | | | | | udev: use list.h instead of udev_list_node
| * | udevd: remove unused list nodeSimon Peeters2017-11-221-1/+0
| | |
| * | udevd: use list.h instead of udev_list_nodeSimon Peeters2017-11-222-27/+20
| | |
View Lorry Controller Status