| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
We already used in_addr_ifindex_to_string() which internally appends the
ifindex to the address with % if necessary. It's simply wrong to attach the
intreface a second time with % then. Also, it breaks stuff that cannot
deal with that. Hence, let's reformat this, and add the ifindex as a
comment to the output, and drop the second % suffix.
|
|
|
|
|
|
|
| |
All our bus calls validate whether the specified device is a loopback
device anyway on the server side. Let's hence simplify the client,
there's no value in optimizing error paths after all. But there is value
in simpler code.
|
|
|
|
|
|
|
|
|
|
|
| |
it's a bit confusing that we take two interfaces for verbs such as "dns"
or "domain": once after the verb, and once as --interface=. While
there's logic behind it, let's make this least surprising: if either is
specified be happy.
This means "resolvectl -i foo dns" is now equivalent to "resolvectl dns
foo …". Note that this is a tweak only, to minimize surprises. We don't
document this alternative syntax, and shouldn't to keep things simple.
|
|
|
|
|
|
|
|
|
|
| |
Let's compare the ifname passed in with what is set already if there is
something set already. Complain in that case. This makes commands such
as "resolvectl -i foo dns bar" less weird, as we'll refuse the duplicate
ifname specifications.
Also, free the old arg_ifname right before assigning the new, instead of
doing so in advance.
|
|
|
|
|
|
|
|
|
| |
This information is useful to pass back to the caller, as it tells us
where we found the answer.
(While we are at it, fix the socket level for the RECVERR logic)
Fixes: #9778
|
|\
| |
| | |
rc-local-generator message tweak
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Let's be more explicit, and not use LOG_WARNING log level when there's
nothing really wrong.
Fixes: #11044
Follow-up for: #10955
|
|/ |
|
|
|
|
| |
Plus be more specific about where the badges point to.
|
|
|
|
| |
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
|
|\
| |
| | |
travis: also run the tests built with clang under ASan+UBsan
|
| |
| |
| |
| | |
See https://clang.llvm.org/docs/AddressSanitizer.html#symbolizing-the-reports
|
| | |
|
|\ \
| | |
| | | |
trick out ubsan
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
sockaddr_un.sun_path[]
Linux is stupid and sometimes returns a "struct sockaddr_un" that is
longer than its fields, as it NUL terminates .sun_path[] even if it has
full length. ubsan detects this, rightfully. Since this is a Linux
misdesign let's trick out ubsan a bit.
Fixes: #11024
|
| | |
| | |
| | |
| | | |
It's soo long, let's make this more readable.
|
|/ / |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Change the man page to recommend setting AM_DISTCHECK_CONFIGURE_FLAGS
instead of DISTCHECK_CONFIGURE_FLAGS. This is the recommended way from
the automake manual, as otherwise the flag can't be overridden by the
user with something like:
DISTCHECK_CONFIGURE_FLAGS=--some-additional-flags make distcheck
References:
https://www.gnu.org/software/automake/manual/html_node/Checking-the-Distribution.html
https://osmocom.org/issues/3718
|
| |
| |
| |
| |
| | |
To make sure the change event is emitted and udev db is updated
after metadata changes.
|
|\ \
| | |
| | | |
missing: separate missing.h more
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
Tiny coding style fixes
|
| | | | |
|
| |/ / |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
The current use of literal + replaceable is pretty ugly as it usually
ends up with cgroup_disable= rendered in quotes, which looks really
weird, and this doesn't conform with others of a similar type (for
example, the earlier `DefaultDependencies=no` discussion in the same
file.
|
|\ \ \
| | | |
| | | | |
optionally output tables as JSON
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
The table cell reusing code is supposed to be an internal memory
optimization, and not more. This means behaviour should be the same as
if we wouldn't reuse cells.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This adds a per-cell option for uppercasing displayed strings.
Implicitly turn this on for the header row. The fact that we format the
table header in uppercase is a formatting thing after all, hence should
be applied by the formatter, i.e. the table display code.
Moreover, this provides us with the benefit that we can more nicely
reuse the specified table headers as JSON field names, like we already
do: json field names are usually not uppercase.
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This works now:
$ loginctl list-session --output=json-pretty
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Since .timespan and .timestamp are unionized on top of each other this
doesn't actually matter, but it is still more correct to address it
under it's correct name.
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Just a pretty way to determine whether the selected output mode is a
JSON output mode.
|
| | | |
| | | |
| | | |
| | | | |
OutputMode
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Typically we want to enable color when colors_enabled() says so, hence
let's automatize this.
|
| | |/
| |/| |
|
|\ \ \
| | | |
| | | | |
tweak root cgroup attribute fiddling for cgroupsv1 again
|
| | | |
| | | |
| | | |
| | | |
| | | | |
Let's follow our recommendations from CODING_STYLE and suffix unit file
settings with "=" everywhere.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
In the kernel sources attempts to write to either are refused with
EINVAL. Not sure why these attributes are exported anyway on cgroupsv1,
but this means we really should ignore them altogether.
This simplifies our code as this means cgroupsv1 is more alike cgroupsv2
in this regard.
Fixes: #10969
|