summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Revert "mkosi: Drop python-docutils"Daan De Meyer2023-04-056-0/+6
| | | | | | | This reverts commit be266f49d6b7e3f021e2a07f937d39d1f14a283d. Turns out we installed this because it's required by the bpf selftests so let's keep it intact.
* service: use newdup() where appropriateLennart Poettering2023-04-051-2/+1
|
* Merge pull request #27137 from yuwata/id128-get-machineYu Watanabe2023-04-0514-90/+112
|\ | | | | sd-id128: introduce id128_get_machine() and _at()
| * machine-id-setup: do not read host's machine ID when root directory is specifiedYu Watanabe2023-04-051-10/+5
| | | | | | | | | | | | | | | | | | | | If a root directory is specified, and e.g. /var under the root directory is a symlink to the host's /var, then we wrongly read host's machine ID, even if O_NOFOLLOW is set. Let's chase the path with CHASE_NOFOLLOW to refuse such case. Also, refuse null ID, otherwise we may setup machine ID with NULL.
| * machine-id-setup: use id128_get_machine() at one more placeYu Watanabe2023-04-051-4/+1
| |
| * discover-image: use id128_get_machine() at one more placeYu Watanabe2023-04-051-17/+3
| |
| * specifier: always convert missing machine-id file to EUNATCHYu Watanabe2023-04-052-14/+4
| | | | | | | | Then, use id128_get_machine().
| * nspawn: ignore NULL machine ID in the containerYu Watanabe2023-04-051-11/+1
| | | | | | | | | | | | | | | | Previously, when the NULL (all zero) machine ID is configured in the container, nspawn refused to execute. Now id128_get_machine() is used, so NULL machine ID is refused with -ENOMEDIUM, and fallback to specified UUID or randomly generated one.
| * repart: use id128_get_machine()Yu Watanabe2023-04-051-16/+6
| | | | | | | | | | This also makes that the seed is actually randomized when the read machine ID is NULL.
| * test: add tests for id128_get_machine() and _at()Yu Watanabe2023-04-051-0/+10
| |
| * sd-id128: introduce id128_get_machine() and id128_get_machine_at()Yu Watanabe2023-04-052-0/+37
| |
| * fd-util: introduce dir_fd_is_root_or_cwd()Yu Watanabe2023-04-053-8/+6
| |
| * test: add tests for ID128_REFUSE_NULLYu Watanabe2023-04-051-0/+20
| |
| * sd-id128: introduce ID128_REFUSE_NULL flagYu Watanabe2023-04-053-10/+19
| |
* | various: simplify calls to parse_boolean_argument()Zbigniew Jędrzejewski-Szmek2023-04-055-56/+30
| | | | | | | | | | parse_boolean_argument() returns the same information via both the output argument and normal return.
* | tpm2: fix nits from PR #26185William Roberts2023-04-043-7/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | Fixes: - Comment style - Alignment style - cleanup macro usage - incorrect error message[1] 1. Thanks to tempusfugit991@gmail.com for pointing out the error message mistake. Signed-off-by: William Roberts <william.c.roberts@intel.com>
* | test/test-functions: fix typo in install_suse_systemd()Thomas Blume2023-04-041-1/+1
| |
* | update TODOLennart Poettering2023-04-041-8/+0
| | | | | | | | As it turns out RuntimeDirectoryPreserve= already supports such a mode.
* | update TODOLennart Poettering2023-04-041-0/+4
| |
* | execute: add one more assert()Lennart Poettering2023-04-041-0/+2
| |
* | Merge pull request #27128 from keszybz/sd-bus-docs-and-error-messagesZbigniew Jędrzejewski-Szmek2023-04-0412-242/+274
|\ \ | | | | | | Improvements to man pages for systemd.service, sd-bus, and better error messages
| * | sd-bus: use macros for standard bus error names consistentlyZbigniew Jędrzejewski-Szmek2023-04-046-98/+115
| | | | | | | | | | | | | | | Also add definitions for a few names that didn't have them and update the list in the man page.
| * | core: a more informative error when SetProperties/StartTransientUnit failsZbigniew Jędrzejewski-Szmek2023-04-041-9/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I was changing how some properties are appended to the StartTransientUnit call and messed up the message contents. When something is wrong with how the message is structed, we would return a very generic "Failed to start transient service unit: No such device or address". Mention that it was property setting that failed, and translate ENXIO to a different message. bus_unit_set_properties() or any of the children it calls may also return other errors, in particular EBADMSG or ENOMEM, but the error message that is generated for those is understandable, so we don't need to "translate" them explicitly. bus_unit_set_properties() is called from two places, so it seems nicer to generate the message internally, rather than ask the caller to do that. Also, now bus_unit_set_properties() always sets <error>, which is nicer for the callers.
| * | man/sd_bus_message_open_container: mention two common errorsZbigniew Jędrzejewski-Szmek2023-04-041-1/+15
| | |
| * | man/systemd.service: add example for char prefixesZbigniew Jędrzejewski-Szmek2023-04-041-1/+12
| | | | | | | | | | | | | | | The prefixes can be specified for any part of the command. The docs imply this, but it's not entirely obvious. Let's add an example.
| * | man: move description of command line substitution out of ExecStart=Zbigniew Jędrzejewski-Szmek2023-04-041-76/+69
| | | | | | | | | | | | | | | | | | | | | | | | The description was split — part was under ExecStart= and part in "Command lines". Now the whole generic part is moved to the separate section, and under ExecStart= only the stuff that is specific to that option is described. This just moves the text and removes some repetitions.
| * | core: unify two similar paths, avoid formatting of unused stringZbigniew Jędrzejewski-Szmek2023-04-041-26/+21
| | | | | | | | | | | | | | | | | | | | | | | | After 'if (DEBUG_LOGGING)' is added, the two call sites are almost identical, except that we forgot LOG_UNIT_INVOCATION_ID(unit). I removed the handling of the log_oom(). It's a debug message only after all, and it's unlikely to fail.
| * | core: simplify unit_escape_setting()Zbigniew Jędrzejewski-Szmek2023-04-042-17/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The function had a provision for NULL input, and would return NULL, but that looks like an error and all callers pass in a non-NULL arg and report oom on NULL. So assert that the input is non-NULL. All callers specifed the output buffer, so we can simplify the logic to only make an allocation if appropriate and change the return type to 'const *'. No functional change.
| * | core: typos in commentsZbigniew Jędrzejewski-Szmek2023-04-044-15/+14
| | |
* | | man: mention -o option for systemd-journal-remoteYu Watanabe2023-04-041-0/+2
| |/ |/|
* | service: minor modernizationsLennart Poettering2023-04-041-13/+13
| |
* | manager: remove transient unit directory during startupZbigniew Jędrzejewski-Szmek2023-04-041-0/+4
| | | | | | | | | | | | | | | | | | | | I was testing transient units and user@.service crashed. I restarted it, and tried to create a transient unit. It failed because /run/user/1000/systemd/transient/ remained after the previous aborted run: Failed to start transient service unit: Unit run-u0.service was already loaded or has a fragment file. Remove the directory during initial startup so we don't get confused by our own files.
* | update TODOLennart Poettering2023-04-041-0/+4
| |
* | service: dump fdstore contents also in free-form debug dumpLennart Poettering2023-04-041-0/+39
| |
* | Merge pull request #27122 from yuwata/id128-atDaan De Meyer2023-04-046-26/+117
|\ \ | | | | | | undefined
| * | test: add tests for id128_{read,write}_at()Yu Watanabe2023-04-041-0/+74
| | |
| * | sd-id128: introduce id128_write_at()Yu Watanabe2023-04-042-4/+8
| | |
| * | sd-id128: introduce id128_read_at()Yu Watanabe2023-04-042-4/+10
| | |
| * | sd-id128: rename Id128FormatFlag -> Id128FlagYu Watanabe2023-04-042-13/+13
| | | | | | | | | | | | As the flag is not only for formatting.
| * | sd-id128: rename argument and add missing assertionYu Watanabe2023-04-042-6/+10
| | |
| * | Revert "sd-id128: make id128_read() optionally take root directory"Yu Watanabe2023-04-045-13/+16
| | | | | | | | | | | | This reverts commit 830e52caa2bf1a29f56cb93e7ed85acb1bda11c3.
* | | chase: fix error handlingYu Watanabe2023-04-041-2/+2
|/ / | | | | | | Fixes a bug introduced by 63bfd52f48a772c86ff84e3a1ba1fcd19e0008f8.
* | src: changed usage of basename() to path_extract_filename().OMOJOLA JOSHUA DAMILOLA2023-04-042-7/+19
| | | | | | | | TODO.
* | Merge pull request #27114 from keszybz/trivial-cleanupsLuca Boccassi2023-04-035-17/+9
|\ \ | | | | | | Trivial cleanups
| * | shared/exec-util: reduce scope of iterator variablesZbigniew Jędrzejewski-Szmek2023-04-031-6/+3
| | |
| * | core/service: inline one variableZbigniew Jędrzejewski-Szmek2023-04-031-3/+1
| | |
| * | basic/fs-util: typo fixZbigniew Jędrzejewski-Szmek2023-04-031-1/+1
| | |
| * | man/systemd-sysext: minor grammar optimizationsZbigniew Jędrzejewski-Szmek2023-04-031-2/+2
| | |
| * | basic/mkdir: simplify error handlingZbigniew Jędrzejewski-Szmek2023-04-031-5/+2
| |/ | | | | | | | | | | | | | | | | | | If we created the dir successfully, we let chmod_and_chown_at() do its thing and shouldn't go into the part where we check if the existing directory has the right permissions and ownership and possibly adjust them. The code was doing that, by relying on the fact that chmod_and_chown_at() does not return -EEXIST. That's probably true, but seems unnecessarilly complicated. Follow-up for c1b1492a94b43ca636eb383c3b058feff27ff7b1.
* | pid1: drop two spurious empty lineLennart Poettering2023-04-031-2/+0
| |
View Lorry Controller Status