summaryrefslogtreecommitdiff
path: root/src
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #11355 from yuwata/rfe-11343Zbigniew Jędrzejewski-Szmek2019-01-082-7/+19
|\ | | | | conf-parse: accept whitespaces before comments
| * test: add testcases for the lines prefixed with whitespacesYu Watanabe2019-01-081-5/+17
| |
| * conf-parser: accept whitespaces before commentsYu Watanabe2019-01-081-1/+1
| | | | | | | | Closes #11343.
| * conf-parser: mention that unknown lvalue is ignoredYu Watanabe2019-01-081-1/+1
| |
* | Merge pull request #11352 from yuwata/rfe-11348Lennart Poettering2019-01-081-36/+46
|\ \ | | | | | | core/socket: logs address or path which fails to be initialized
| * | core/socket: logs address or path which fails to be initializedYu Watanabe2019-01-081-8/+19
| | | | | | | | | | | | Closes #11348.
| * | core/socket: use _cleanup_ attribute for closing fds on errorYu Watanabe2019-01-081-29/+28
| | |
| * | core/socket: use log_unit_*()Yu Watanabe2019-01-081-4/+4
| | |
* | | cat: add --stderr-priority optionMichael Sloan2019-01-081-16/+34
| | |
* | | Merge pull request #11344 from poettering/various-fixesZbigniew Jędrzejewski-Szmek2019-01-0814-59/+55
|\ \ \ | | | | | | | | multiple trivial fixlets, across the tree
| * | | tree-wide: always declare bitflag enums the same wayLennart Poettering2019-01-078-44/+44
| | | | | | | | | | | | | | | | | | | | let's always use the 1 << x syntax. No change of behaviour or even of the compiled binary.
| * | | json: handle NULL explicitly in json_variant_has_type()Lennart Poettering2019-01-071-0/+2
| | | |
| * | | json: fix typoLennart Poettering2019-01-071-1/+1
| | | |
| * | | json: teach json_log() the new SYNTHETIC_ERRNO() logicLennart Poettering2019-01-072-5/+1
| | | |
| * | | loop-util: tweak codepath when a loopback file is "created" from an existing ↵Lennart Poettering2019-01-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | block device Be more careful with initialized of the 'relinquished' boolean field, and let's return the fd, like we do for the regular codepath, too.
| * | | loop-util: minor simplificationLennart Poettering2019-01-071-2/+1
| | | |
| * | | fsck: use symbolic names where we have themLennart Poettering2019-01-071-1/+1
| | | |
| * | | stat-util: remove spurious newlineLennart Poettering2019-01-071-1/+0
| | | |
| * | | env-util: normalize one more flags enumLennart Poettering2019-01-071-3/+3
| | | |
* | | | udevadm: refuse to run trigger, control, settle and monitor commands in chrootYu Watanabe2019-01-084-0/+24
| |_|/ |/| | | | | | | | Closes #11333.
* | | Merge pull request #11351 from yuwata/ethtool-port-tableYu Watanabe2019-01-082-11/+11
|\ \ \ | | | | | | | | ethtool: cleanups for port_table
| * | | ethtool: minimize the size of port_tableYu Watanabe2019-01-081-3/+3
| | | | | | | | | | | | | | | | Note that `_NET_DEV_PORT_MAX` is 0x100.
| * | | ethtool: use kernel defined values for NET_DEV_PORT_*Yu Watanabe2019-01-081-8/+8
| | |/ | |/|
* | | Merge pull request #11232 from yuwata/fix-9130-alternativeYu Watanabe2019-01-081-20/+14
|\ \ \ | |/ / |/| | network: always check link is ready when address is updated
| * | network: always check link is ready when address is updatedYu Watanabe2018-12-231-10/+9
| | |
| * | network: decrease and fix indentationYu Watanabe2018-12-231-10/+5
| | |
* | | udev: rework how we handle the return value from spawned programsZbigniew Jędrzejewski-Szmek2019-01-072-30/+20
| |/ |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When running PROGRAM="...", we would log systemd-udevd[447]: Failed to wait spawned command '...': Input/output error no matter why the program actually failed, at error level. The code wouldn't distinguish between an internal failure and a failure in the program being called and run sd_event_exit(..., -EIO) on any kind of error. EIO is rather misleading here, becuase it suggests a serious error. on_spawn_sigchld is updated to set the return code to distinguish failure to spawn, including the program being killed by a signal (a negative return value), and the program failing (positive return value). The logging levels are adjusted, so that for PROGRAM= calls, which are essentially "if" statements, we only log at debug level (unless we get a timeout or segfault or another unexpected error).
* | Merge pull request #11327 from keszybz/revert-dbus-addressLennart Poettering2019-01-071-0/+30
|\ \ | | | | | | Revert "pam_systemd: drop setting DBUS_SESSION_BUS_ADDRESS"
| * | pam_systemd: set $DBUS_SESSION_BUS_ADDRESS unconditionallyZbigniew Jędrzejewski-Szmek2019-01-061-12/+0
| | | | | | | | | | | | | | | | | | | | | | | | There's very little lost if the variable is set for a socket that isn't connectible, but a lot lost (races, ...) if it's not set but the socket exists. Also, drop the FIXME note, since we don't plan to revert this revert any time soon.
| * | Revert "pam_systemd: drop setting DBUS_SESSION_BUS_ADDRESS"Zbigniew Jędrzejewski-Szmek2019-01-041-0/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 2b2b7228bffef626fe8e9f131095995f3d50ee3b. Fixes #11293. Removing the environment variable causes problems, e.g. Xfce and Chromium and ... don't communicate with the running dbus instance. If they attempt to start their own instance, things become even more confusing. Those packages could be fixed one by one, but removing the variable right now is causing too many problems.
* | | Merge pull request #11252 from evverx/use-asan-wrapper-on-travis-ciFrantisek Sumsal2019-01-063-5/+13
|\ \ \ | | | | | | | | travis: run PID1, journald and everything else under ASan+UBsan
| * | | journal: rely on _cleanup_free_ to free a temporary string used in ↵Evgeny Vereshchagin2018-12-291-5/+2
| | | | | | | | | | | | | | | | | | | | | | | | client_context_read_cgroup Closes https://github.com/systemd/systemd/issues/11253.
| * | | tests: reproduce https://github.com/systemd/systemd/issues/11251Evgeny Vereshchagin2018-12-291-0/+8
| | | |
| * | | travis: skip test-bpf on Travis CIEvgeny Vereshchagin2018-12-241-0/+3
| | |/ | |/| | | | | | | More generally IPAddress[Allow|Deny] are broken in docker and lxc containers.
* | | Merge pull request #11241 from bengal/lldp-802-3-subtypesLennart Poettering2019-01-062-3/+17
|\ \ \ | | | | | | | | lldp: add 802.3 OUI subtype definitions
| * | | lldp: add 802.3 OUI subtype definitionsBeniamino Galvani2018-12-212-0/+12
| | | |
| * | | lldp: fix references to IEEE standardBeniamino Galvani2018-12-211-3/+5
| | | | | | | | | | | | | | | | | | | | It's 802.1AB, not 802.3AB. Also, the clause numbers referenced the old 2005 standard superseded by one from 2009.
* | | | Merge pull request #11328 from keszybz/static-array-size-declarationsLennart Poettering2019-01-0618-24/+32
|\ \ \ \ | | | | | | | | | | Use a c99 feature for additional code analysis
| * | | | Use c99 static array size declarations in exported functions tooZbigniew Jędrzejewski-Szmek2019-01-045-6/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It seems quite useful to provide this additional information in public exported functions. This is a c99 feature, not supported in C++. Without the check in _sd-common.h: FAILED: test-bus-vtable-cc@exe/src_libsystemd_sd-bus_test-bus-vtable-cc.cc.o ... In file included from ../src/libsystemd/sd-bus/test-bus-vtable-cc.cc:9: In file included from ../src/systemd/sd-bus-vtable.h:26: In file included from ../src/systemd/sd-bus.h:26: ../src/systemd/sd-id128.h:38:47: error: static array size is a C99 feature, not permitted in C++ char *sd_id128_to_string(sd_id128_t id, char s[static SD_ID128_STRING_MAX]); ^ In .c files, I opted to use the define for consistency, even though we don't support compilation with a C++ compiler, so the unconditional keyword would work too.
| * | | | tree-wide: use c99 static for array size declarationsZbigniew Jędrzejewski-Szmek2019-01-0413-18/+18
| | |_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | https://hamberg.no/erlend/posts/2013-02-18-static-array-indices.html This only works with clang, unfortunately gcc doesn't seem to implement the check (tested with gcc-8.2.1-5.fc29.x86_64). Simulated error: [2/3] Compiling C object 'systemd-nspawn@exe/src_nspawn_nspawn.c.o'. ../src/nspawn/nspawn.c:3179:45: warning: array argument is too small; contains 15 elements, callee requires at least 16 [-Warray-bounds] candidate = (uid_t) siphash24(arg_machine, strlen(arg_machine), hash_key); ^ ~~~~~~~~ ../src/basic/siphash24.h:24:64: note: callee declares array parameter as static here uint64_t siphash24(const void *in, size_t inlen, const uint8_t k[static 16]); ^~~~~~~~~~~~
* | | | Print the systemd version in a format that dracut likesZbigniew Jędrzejewski-Szmek2019-01-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - systemd 240-63-g4199f68+ + systemd 240 (240-63-g4199f68+) Sad, but easy. Fixes #11330.
* | | | meson: declare version.h as dep for libbasicZbigniew Jędrzejewski-Szmek2019-01-051-0/+2
|/ / / | | | | | | | | | | | | | | | "meson build && ninja -C build systemd-cat" would fail on missing version.h. Fixes #11335.
* | | Merge pull request #11244 from yuwata/revert-udev-changesZbigniew Jędrzejewski-Szmek2019-01-034-37/+58
|\ \ \ | | | | | | | | udev: revert bind/unbind patch and one more
| * | | test: add test for sending/receiving an invalid deviceYu Watanabe2019-01-021-27/+54
| | | |
| * | | Revert "udevd: configure a child process name for worker processes"Yu Watanabe2019-01-021-1/+1
| | | | | | | | | | | | | | | | This reverts commit 49f3ee7e74c714f55aab395c080b1099fc17f7fd.
| * | | Revert "sd-device: ignore bind/unbind events for now"Yu Watanabe2019-01-021-9/+0
| | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 56c886dc7ed5b2bb0882ba85136f4070545bfc1b. Fixes #11277 and #11299.
| * | | sd-device: fix segfault when error occurs in device_new_from_{nulstr,strv}()Yu Watanabe2018-12-301-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | As devpath may not be set yet. When debug logging is enabled, log_device_*() calls sd_device_get_sysname(). So, we should not assume that devpath is always set. Fixes #11258.
* | | | Merge pull request #11250 from yuwata/dhcp-coding-style-fixesZbigniew Jędrzejewski-Szmek2019-01-032-19/+18
|\ \ \ \ | | | | | | | | | | dhcp,network: trivial coding style fixes
| * | | | network: fix indentationYu Watanabe2018-12-231-1/+1
| | | | |
| * | | | dhcp: drop unnecessary bracketsYu Watanabe2018-12-231-2/+1
| | | | |