| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| | |
conf-parse: accept whitespaces before comments
|
| | |
|
| |
| |
| |
| | |
Closes #11343.
|
| | |
|
|\ \
| | |
| | | |
core/socket: logs address or path which fails to be initialized
|
| | |
| | |
| | |
| | | |
Closes #11348.
|
| | | |
|
| | | |
|
| | | |
|
|\ \ \
| | | |
| | | | |
multiple trivial fixlets, across the tree
|
| | | |
| | | |
| | | |
| | | |
| | | | |
let's always use the 1 << x syntax. No change of behaviour or even of
the compiled binary.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
block device
Be more careful with initialized of the 'relinquished' boolean field,
and let's return the fd, like we do for the regular codepath, too.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |_|/
|/| |
| | |
| | | |
Closes #11333.
|
|\ \ \
| | | |
| | | | |
ethtool: cleanups for port_table
|
| | | |
| | | |
| | | |
| | | | |
Note that `_NET_DEV_PORT_MAX` is 0x100.
|
| | |/
| |/| |
|
|\ \ \
| |/ /
|/| | |
network: always check link is ready when address is updated
|
| | | |
|
| | | |
|
| |/
|/|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
When running PROGRAM="...", we would log
systemd-udevd[447]: Failed to wait spawned command '...': Input/output error
no matter why the program actually failed, at error level.
The code wouldn't distinguish between an internal failure and a failure in the
program being called and run sd_event_exit(..., -EIO) on any kind of error. EIO
is rather misleading here, becuase it suggests a serious error.
on_spawn_sigchld is updated to set the return code to distinguish failure to
spawn, including the program being killed by a signal (a negative return value),
and the program failing (positive return value).
The logging levels are adjusted, so that for PROGRAM= calls, which are
essentially "if" statements, we only log at debug level (unless we get a
timeout or segfault or another unexpected error).
|
|\ \
| | |
| | | |
Revert "pam_systemd: drop setting DBUS_SESSION_BUS_ADDRESS"
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
There's very little lost if the variable is set for a socket that isn't
connectible, but a lot lost (races, ...) if it's not set but the socket exists.
Also, drop the FIXME note, since we don't plan to revert this revert any time
soon.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This reverts commit 2b2b7228bffef626fe8e9f131095995f3d50ee3b.
Fixes #11293.
Removing the environment variable causes problems, e.g. Xfce and Chromium and
... don't communicate with the running dbus instance. If they attempt to start their
own instance, things become even more confusing. Those packages could be fixed
one by one, but removing the variable right now is causing too many problems.
|
|\ \ \
| | | |
| | | | |
travis: run PID1, journald and everything else under ASan+UBsan
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
client_context_read_cgroup
Closes https://github.com/systemd/systemd/issues/11253.
|
| | | | |
|
| | |/
| |/|
| | |
| | | |
More generally IPAddress[Allow|Deny] are broken in docker and lxc containers.
|
|\ \ \
| | | |
| | | | |
lldp: add 802.3 OUI subtype definitions
|
| | | | |
|
| | | |
| | | |
| | | |
| | | |
| | | | |
It's 802.1AB, not 802.3AB. Also, the clause numbers referenced the old 2005
standard superseded by one from 2009.
|
|\ \ \ \
| | | | |
| | | | | |
Use a c99 feature for additional code analysis
|
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | |
| | | | | |
It seems quite useful to provide this additional information in public exported
functions.
This is a c99 feature, not supported in C++. Without the check in _sd-common.h:
FAILED: test-bus-vtable-cc@exe/src_libsystemd_sd-bus_test-bus-vtable-cc.cc.o
...
In file included from ../src/libsystemd/sd-bus/test-bus-vtable-cc.cc:9:
In file included from ../src/systemd/sd-bus-vtable.h:26:
In file included from ../src/systemd/sd-bus.h:26:
../src/systemd/sd-id128.h:38:47: error: static array size is a C99 feature, not permitted in C++
char *sd_id128_to_string(sd_id128_t id, char s[static SD_ID128_STRING_MAX]);
^
In .c files, I opted to use the define for consistency, even though we don't support
compilation with a C++ compiler, so the unconditional keyword would work too.
|
| | |_|/
| |/| |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
https://hamberg.no/erlend/posts/2013-02-18-static-array-indices.html
This only works with clang, unfortunately gcc doesn't seem to implement the check
(tested with gcc-8.2.1-5.fc29.x86_64).
Simulated error:
[2/3] Compiling C object 'systemd-nspawn@exe/src_nspawn_nspawn.c.o'.
../src/nspawn/nspawn.c:3179:45: warning: array argument is too small; contains 15 elements, callee requires at least 16 [-Warray-bounds]
candidate = (uid_t) siphash24(arg_machine, strlen(arg_machine), hash_key);
^ ~~~~~~~~
../src/basic/siphash24.h:24:64: note: callee declares array parameter as static here
uint64_t siphash24(const void *in, size_t inlen, const uint8_t k[static 16]);
^~~~~~~~~~~~
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
- systemd 240-63-g4199f68+
+ systemd 240 (240-63-g4199f68+)
Sad, but easy.
Fixes #11330.
|
|/ / /
| | |
| | |
| | |
| | |
| | | |
"meson build && ninja -C build systemd-cat" would fail on missing version.h.
Fixes #11335.
|
|\ \ \
| | | |
| | | | |
udev: revert bind/unbind patch and one more
|
| | | | |
|
| | | |
| | | |
| | | |
| | | | |
This reverts commit 49f3ee7e74c714f55aab395c080b1099fc17f7fd.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This reverts commit 56c886dc7ed5b2bb0882ba85136f4070545bfc1b.
Fixes #11277 and #11299.
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
As devpath may not be set yet.
When debug logging is enabled, log_device_*() calls
sd_device_get_sysname(). So, we should not assume that devpath is always
set.
Fixes #11258.
|
|\ \ \ \
| | | | |
| | | | | |
dhcp,network: trivial coding style fixes
|
| | | | | |
|
| | | | | |
|