From 62c72c60b5e6c0712a45b1feccc6cc18151efa9c Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 29 Mar 2023 18:06:00 +0200 Subject: units: let's establish the coredump socket before writting core_pattern sysctl It's a bit nicer if we only write the sysctl core_pattern once the coredump socket is established, since it's the backend for the handler. Given the systemd-coredump.socket basically has no dependencies that run before it this should not really make things slower or so, it just removes the tiny window where core pattern is in effect that wants to connect to the backend socket but cannot. The status quo isn't terrible, and not too different in effect: either way, until the socket unit is up we won't process coredumps. It's mostly what kind of behaviour you get then: an error due to /bin/false being invoked, or an error because systemd-coredump can't connect to its socket. After this patch we'll exclusively see the former. --- units/systemd-coredump.socket | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/units/systemd-coredump.socket b/units/systemd-coredump.socket index 565374698d..a2d457fc02 100644 --- a/units/systemd-coredump.socket +++ b/units/systemd-coredump.socket @@ -11,7 +11,7 @@ Description=Process Core Dump Socket Documentation=man:systemd-coredump(8) DefaultDependencies=no -Before=shutdown.target +Before=shutdown.target systemd-sysctl.service Conflicts=shutdown.target [Socket] -- cgit v1.2.1