From ac2474e4ffea1927a24d0cec878d93cb854e80b0 Mon Sep 17 00:00:00 2001 From: YmrDtnJu Date: Sat, 6 Jun 2020 12:42:01 +0200 Subject: basic: New function fstype_is_blockdev_backed for fstypes that need a blockdev The function returns true if the specified filesystem requires a block device. --- src/basic/mountpoint-util.c | 10 ++++++++++ src/basic/mountpoint-util.h | 1 + 2 files changed, 11 insertions(+) diff --git a/src/basic/mountpoint-util.c b/src/basic/mountpoint-util.c index 0b3587ff55..d4a621c7ae 100644 --- a/src/basic/mountpoint-util.c +++ b/src/basic/mountpoint-util.c @@ -338,6 +338,16 @@ bool fstype_is_api_vfs(const char *fstype) { "tracefs"); } +bool fstype_is_blockdev_backed(const char *fstype) { + const char *x; + + x = startswith(fstype, "fuse."); + if (x) + fstype = x; + + return !streq(fstype, "9p") && !fstype_is_network(fstype) && !fstype_is_api_vfs(fstype); +} + bool fstype_is_ro(const char *fstype) { /* All Linux file systems that are necessarily read-only */ return STR_IN_SET(fstype, diff --git a/src/basic/mountpoint-util.h b/src/basic/mountpoint-util.h index 5398836fed..ab4ed19394 100644 --- a/src/basic/mountpoint-util.h +++ b/src/basic/mountpoint-util.h @@ -14,6 +14,7 @@ int path_is_mount_point(const char *path, const char *root, int flags); bool fstype_is_network(const char *fstype); bool fstype_is_api_vfs(const char *fstype); +bool fstype_is_blockdev_backed(const char *fstype); bool fstype_is_ro(const char *fsype); bool fstype_can_discard(const char *fstype); bool fstype_can_uid_gid(const char *fstype); -- cgit v1.2.1 From c15ab81ed9fa9437fdc31b6761ad331f6fd52400 Mon Sep 17 00:00:00 2001 From: YmrDtnJu Date: Mon, 8 Jun 2020 19:25:18 +0200 Subject: mount-tool: Replace fstype_is_{network,api_vfs} with fstype_is_blockdev_backed Not every filesystem that is not a network filesystem and also not an API VFS filesystem has a corresponding block device. --- src/mount/mount-tool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mount/mount-tool.c b/src/mount/mount-tool.c index 469c14271c..ea86a6e06a 100644 --- a/src/mount/mount-tool.c +++ b/src/mount/mount-tool.c @@ -364,7 +364,7 @@ static int parse_argv(int argc, char *argv[]) { return log_error_errno(SYNTHETIC_ERRNO(EINVAL), "At most two arguments required."); - if (arg_mount_type && (fstype_is_api_vfs(arg_mount_type) || fstype_is_network(arg_mount_type))) { + if (arg_mount_type && !fstype_is_blockdev_backed(arg_mount_type)) { arg_mount_what = strdup(argv[optind]); if (!arg_mount_what) return log_oom(); @@ -1463,7 +1463,7 @@ static int run(int argc, char* argv[]) { if (arg_action == ACTION_UMOUNT) return action_umount(bus, argc, argv); - if ((!arg_mount_type || !fstype_is_network(arg_mount_type)) + if ((!arg_mount_type || fstype_is_blockdev_backed(arg_mount_type)) && !path_is_normalized(arg_mount_what)) { log_error("Path contains non-normalized components: %s", arg_mount_what); return -EINVAL; -- cgit v1.2.1