From 33de6b57a82a70a5b1e6991d0eb459f5c49578f9 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 29 May 2018 17:12:39 +0200 Subject: efi: explicitly cast physical address to UINTN when converting to/from pointers UINTN is the integer type equalling the native ptr size. Let's fix the casting warnings described in #7788 by casting the the pointers and values to this type first. That way we cast integers to the right size first before turning them into pointers, and pointers are first covnerted to integers of the right size before converting them into integers. Not tested, since I lack i386 EFI systems, but I think this is simple enough to be correct event without testing. Fixes: #7788 --- src/boot/efi/linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/boot/efi/linux.c') diff --git a/src/boot/efi/linux.c b/src/boot/efi/linux.c index e8f7651324..1f81f3e771 100644 --- a/src/boot/efi/linux.c +++ b/src/boot/efi/linux.c @@ -128,7 +128,7 @@ EFI_STATUS linux_exec(EFI_HANDLE *image, if (EFI_ERROR(err)) return err; CopyMem((VOID *)(UINTN)addr, cmdline, cmdline_len); - ((CHAR8 *)addr)[cmdline_len] = 0; + ((CHAR8 *)(UINTN)addr)[cmdline_len] = 0; boot_setup->cmd_line_ptr = (UINT32)addr; } -- cgit v1.2.1