From 601185b43da638b1c74153deae01dbd518680889 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Sat, 2 Aug 2014 11:12:21 -0400 Subject: Unify parse_argv style getopt is usually good at printing out a nice error message when commandline options are invalid. It distinguishes between an unknown option and a known option with a missing arg. It is better to let it do its job and not use opterr=0 unless we actually want to suppress messages. So remove opterr=0 in the few places where it wasn't really useful. When an error in options is encountered, we should not print a lengthy help() and overwhelm the user, when we know precisely what is wrong with the commandline. In addition, since help() prints to stdout, it should not be used except when requested with -h or --help. Also, simplify things here and there. --- src/escape/escape.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'src/escape') diff --git a/src/escape/escape.c b/src/escape/escape.c index ba2fb4789f..f2a0721861 100644 --- a/src/escape/escape.c +++ b/src/escape/escape.c @@ -37,8 +37,7 @@ static const char *arg_suffix = NULL; static const char *arg_template = NULL; static bool arg_path = false; -static int help(void) { - +static void help(void) { printf("%s [OPTIONS...] [NAME...]\n\n" "Show system and user paths.\n\n" " -h --help Show this help\n" @@ -47,10 +46,8 @@ static int help(void) { " --template=TEMPLATE Insert strings as instance into template\n" " -u --unescape Unescape strings\n" " -m --mangle Mangle strings\n" - " -p --path When escaping/unescaping assume the string is a path\n", - program_invocation_short_name); - - return 0; + " -p --path When escaping/unescaping assume the string is a path\n" + , program_invocation_short_name); } static int parse_argv(int argc, char *argv[]) { @@ -77,12 +74,13 @@ static int parse_argv(int argc, char *argv[]) { assert(argc >= 0); assert(argv); - while ((c = getopt_long(argc, argv, "hump", options, NULL)) >= 0) { + while ((c = getopt_long(argc, argv, "hump", options, NULL)) >= 0) switch (c) { case 'h': - return help(); + help(); + return 0; case ARG_VERSION: puts(PACKAGE_STRING); @@ -127,7 +125,6 @@ static int parse_argv(int argc, char *argv[]) { default: assert_not_reached("Unhandled option"); } - } if (optind >= argc) { log_error("Not enough arguments."); -- cgit v1.2.1