From 51214cf49195b645bd58b0c41046470908de71d9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Tue, 4 Apr 2023 19:39:04 +0200 Subject: various: simplify calls to parse_boolean_argument() parse_boolean_argument() returns the same information via both the output argument and normal return. --- src/home/homectl.c | 31 ++++++++++--------------------- 1 file changed, 10 insertions(+), 21 deletions(-) (limited to 'src/home') diff --git a/src/home/homectl.c b/src/home/homectl.c index 158164ae81..b265f8741e 100644 --- a/src/home/homectl.c +++ b/src/home/homectl.c @@ -3576,38 +3576,29 @@ static int parse_argv(int argc, char *argv[]) { strv_uniq(arg_fido2_device); break; - case ARG_FIDO2_WITH_PIN: { - bool lock_with_pin; - - r = parse_boolean_argument("--fido2-with-client-pin=", optarg, &lock_with_pin); + case ARG_FIDO2_WITH_PIN: + r = parse_boolean_argument("--fido2-with-client-pin=", optarg, NULL); if (r < 0) return r; - SET_FLAG(arg_fido2_lock_with, FIDO2ENROLL_PIN, lock_with_pin); + SET_FLAG(arg_fido2_lock_with, FIDO2ENROLL_PIN, r); break; - } - case ARG_FIDO2_WITH_UP: { - bool lock_with_up; - - r = parse_boolean_argument("--fido2-with-user-presence=", optarg, &lock_with_up); + case ARG_FIDO2_WITH_UP: + r = parse_boolean_argument("--fido2-with-user-presence=", optarg, NULL); if (r < 0) return r; - SET_FLAG(arg_fido2_lock_with, FIDO2ENROLL_UP, lock_with_up); + SET_FLAG(arg_fido2_lock_with, FIDO2ENROLL_UP, r); break; - } - case ARG_FIDO2_WITH_UV: { - bool lock_with_uv; - - r = parse_boolean_argument("--fido2-with-user-verification=", optarg, &lock_with_uv); + case ARG_FIDO2_WITH_UV: + r = parse_boolean_argument("--fido2-with-user-verification=", optarg, NULL); if (r < 0) return r; - SET_FLAG(arg_fido2_lock_with, FIDO2ENROLL_UV, lock_with_uv); + SET_FLAG(arg_fido2_lock_with, FIDO2ENROLL_UV, r); break; - } case ARG_RECOVERY_KEY: r = parse_boolean(optarg); @@ -3727,8 +3718,6 @@ static int parse_argv(int argc, char *argv[]) { break; case ARG_DROP_CACHES: { - bool drop_caches; - if (isempty(optarg)) { r = drop_from_identity("dropCaches"); if (r < 0) @@ -3736,7 +3725,7 @@ static int parse_argv(int argc, char *argv[]) { break; } - r = parse_boolean_argument("--drop-caches=", optarg, &drop_caches); + r = parse_boolean_argument("--drop-caches=", optarg, NULL); if (r < 0) return r; -- cgit v1.2.1