From 254d1313ae5a69c08c9b93032aaaf3d6083cfc07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 19 Dec 2022 13:07:42 +0100 Subject: tree-wide: use -EBADF for fd initialization -1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary. --- src/import/import-fs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/import/import-fs.c') diff --git a/src/import/import-fs.c b/src/import/import-fs.c index ca5d33c008..d81dd13ffd 100644 --- a/src/import/import-fs.c +++ b/src/import/import-fs.c @@ -100,7 +100,7 @@ static int import_fs(int argc, char *argv[], void *userdata) { _cleanup_(progress_info_free) ProgressInfo progress = {}; _cleanup_free_ char *l = NULL, *final_path = NULL; const char *path = NULL, *local = NULL, *dest = NULL; - _cleanup_close_ int open_fd = -1; + _cleanup_close_ int open_fd = -EBADF; int r, fd; if (argc >= 2) -- cgit v1.2.1