From cd05bb8bafa808f0a40feaaa0e8cc564c0f203a7 Mon Sep 17 00:00:00 2001 From: Tobias Stoeckmann Date: Fri, 2 Dec 2016 00:46:36 +0100 Subject: Spot inconsistent quoting (just one single quote) (#4732) It is possible to specify only one quote in udev rules, which is not detected as an invalid quoting (" instead of "" for empty string). Technically this doesn't lead to a bug, because the string ends in two terminating nul characters at this position, but a user should still be reminded that his configuration is invalid. --- src/libudev/libudev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/libudev/libudev.c') diff --git a/src/libudev/libudev.c b/src/libudev/libudev.c index 63fb05547d..57ce749e07 100644 --- a/src/libudev/libudev.c +++ b/src/libudev/libudev.c @@ -156,7 +156,7 @@ _public_ struct udev *udev_new(void) { /* unquote */ if (val[0] == '"' || val[0] == '\'') { - if (val[len-1] != val[0]) { + if (len == 1 || val[len-1] != val[0]) { log_debug("/etc/udev/udev.conf:%u: inconsistent quoting, skipping line.", line_nr); continue; } -- cgit v1.2.1