From 254d1313ae5a69c08c9b93032aaaf3d6083cfc07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 19 Dec 2022 13:07:42 +0100 Subject: tree-wide: use -EBADF for fd initialization -1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary. --- src/libudev/libudev-queue.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/libudev') diff --git a/src/libudev/libudev-queue.c b/src/libudev/libudev-queue.c index 7ca17fa6c3..7c5bb5500c 100644 --- a/src/libudev/libudev-queue.c +++ b/src/libudev/libudev-queue.c @@ -50,7 +50,7 @@ _public_ struct udev_queue *udev_queue_new(struct udev *udev) { *udev_queue = (struct udev_queue) { .udev = udev, .n_ref = 1, - .fd = -1, + .fd = -EBADF, }; return udev_queue; -- cgit v1.2.1