From 254d1313ae5a69c08c9b93032aaaf3d6083cfc07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 19 Dec 2022 13:07:42 +0100 Subject: tree-wide: use -EBADF for fd initialization -1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary. --- src/random-seed/random-seed.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/random-seed') diff --git a/src/random-seed/random-seed.c b/src/random-seed/random-seed.c index 020840e0df..90890e33f2 100644 --- a/src/random-seed/random-seed.c +++ b/src/random-seed/random-seed.c @@ -320,7 +320,7 @@ static int refresh_boot_seed(void) { struct sha256_ctx hash_state; _cleanup_free_ void *seed_file_bytes = NULL; _cleanup_free_ char *esp_path = NULL; - _cleanup_close_ int seed_fd = -1, dir_fd = -1; + _cleanup_close_ int seed_fd = -EBADF, dir_fd = -EBADF; size_t len; ssize_t n; int r; @@ -485,7 +485,7 @@ static int parse_argv(int argc, char *argv[]) { static int run(int argc, char *argv[]) { _cleanup_free_ struct sha256_ctx *hash_state = NULL; - _cleanup_close_ int seed_fd = -1, random_fd = -1; + _cleanup_close_ int seed_fd = -EBADF, random_fd = -EBADF; bool read_seed_file, write_seed_file, synchronous; size_t seed_size; int r; -- cgit v1.2.1