From 254d1313ae5a69c08c9b93032aaaf3d6083cfc07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 19 Dec 2022 13:07:42 +0100 Subject: tree-wide: use -EBADF for fd initialization -1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary. --- src/reply-password/reply-password.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/reply-password') diff --git a/src/reply-password/reply-password.c b/src/reply-password/reply-password.c index feb1d1ef7c..ce4582afe8 100644 --- a/src/reply-password/reply-password.c +++ b/src/reply-password/reply-password.c @@ -34,7 +34,7 @@ static int send_on_socket(int fd, const char *socket_name, const void *packet, s static int run(int argc, char *argv[]) { _cleanup_(erase_and_freep) char *packet = NULL; - _cleanup_close_ int fd = -1; + _cleanup_close_ int fd = -EBADF; size_t length = 0; int r; -- cgit v1.2.1