From a2eb2267e44580446ecad37e7206e729cfd78155 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Wed, 14 Apr 2021 17:10:36 +0200 Subject: shared/module-util: fix errno value passed to log function If r == 0, no harm done. But if r > 0, this would be interpreted as an errno value, wrongly. --- src/shared/module-util.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) (limited to 'src/shared/module-util.c') diff --git a/src/shared/module-util.c b/src/shared/module-util.c index 587e6369fb..1526f59b0a 100644 --- a/src/shared/module-util.c +++ b/src/shared/module-util.c @@ -20,11 +20,10 @@ int module_load_and_warn(struct kmod_ctx *ctx, const char *module, bool verbose) return log_full_errno(verbose ? LOG_ERR : LOG_DEBUG, r, "Failed to look up module alias '%s': %m", module); - if (!modlist) { - log_full_errno(verbose ? LOG_ERR : LOG_DEBUG, r, - "Failed to find module '%s'", module); - return -ENOENT; - } + if (!modlist) + return log_full_errno(verbose ? LOG_ERR : LOG_DEBUG, + SYNTHETIC_ERRNO(ENOENT), + "Failed to find module '%s'", module); kmod_list_foreach(itr, modlist) { _cleanup_(kmod_module_unrefp) struct kmod_module *mod = NULL; -- cgit v1.2.1