From 2f82562bad423d1190912a4b209647dfac966db2 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 13 Oct 2021 12:38:37 +0200 Subject: alloc-util: add strdupa_safe() + strndupa_safe() and use it everywhere Let's define two helpers strdupa_safe() + strndupa_safe() which do the same as their non-safe counterparts, except that they abort if called with allocations larger than ALLOCA_MAX. This should ensure that all our alloca() based allocations are subject to this limit. afaics glibc offers three alloca() based APIs: alloca() itself, strndupa() + strdupa(). With this we have now replacements for all of them, that take the limit into account. --- src/socket-proxy/socket-proxyd.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/socket-proxy') diff --git a/src/socket-proxy/socket-proxyd.c b/src/socket-proxy/socket-proxyd.c index be0be91f3e..aba483449a 100644 --- a/src/socket-proxy/socket-proxyd.c +++ b/src/socket-proxy/socket-proxyd.c @@ -438,7 +438,8 @@ static int resolve_remote(Connection *c) { service = strrchr(arg_remote_host, ':'); if (service) { - node = strndupa(arg_remote_host, service - arg_remote_host); + node = strndupa_safe(arg_remote_host, + service - arg_remote_host); service++; } else { node = arg_remote_host; -- cgit v1.2.1