From 19193b489841a7bcccda7122ac0849cf6efe59fd Mon Sep 17 00:00:00 2001 From: Avram Lubkin Date: Tue, 16 Aug 2022 08:51:21 -0400 Subject: sysusers: add fsync for passwd (#24324) https://github.com/systemd/systemd/pull/6636 added `fsync()` when temporary shadow, group, and gshadow files are created, but it was not added for passwd. As far as I can tell, this seems to have been an oversight. I'm seeing real world issues where a blank /etc/passwd file is being created if a machine loses power early in the boot process. --- src/sysusers/sysusers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/sysusers') diff --git a/src/sysusers/sysusers.c b/src/sysusers/sysusers.c index dfb703f10e..9c1abf984e 100644 --- a/src/sysusers/sysusers.c +++ b/src/sysusers/sysusers.c @@ -507,7 +507,7 @@ static int write_temporary_passwd(const char *passwd_path, FILE **tmpfile, char break; } - r = fflush_and_check(passwd); + r = fflush_sync_and_check(passwd); if (r < 0) return log_debug_errno(r, "Failed to flush %s: %m", passwd_tmp); -- cgit v1.2.1