From 053254e3cb215df3b8c905bc39b920f8817e1c7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Wed, 21 Nov 2018 10:12:00 +0100 Subject: generators: drop umask calls systemd already sets the umask (see e3b8d0637dd755b3426f3363b2cdad63f738116c). When running under systemd, we don't need to set it. And when *not* running under systemd, for example during development, there is no reason to override the user config. Let's just drop those calls. $ git grep -e 'umask\(' -l 'src/*generator*' |xargs perl -i -0pe 's|^[^\n]*umask\([^\n]+\n\n||gms' --- src/sysv-generator/sysv-generator.c | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/sysv-generator') diff --git a/src/sysv-generator/sysv-generator.c b/src/sysv-generator/sysv-generator.c index 6a1badabd4..c4acdc4a50 100644 --- a/src/sysv-generator/sysv-generator.c +++ b/src/sysv-generator/sysv-generator.c @@ -934,8 +934,6 @@ static int run(int argc, char *argv[]) { if (argc > 1) arg_dest = argv[3]; - umask(0022); - r = lookup_paths_init(&lp, UNIT_FILE_SYSTEM, LOOKUP_PATHS_EXCLUDE_GENERATED, NULL); if (r < 0) return log_error_errno(r, "Failed to find lookup paths: %m"); -- cgit v1.2.1