From 2f82562bad423d1190912a4b209647dfac966db2 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Wed, 13 Oct 2021 12:38:37 +0200 Subject: alloc-util: add strdupa_safe() + strndupa_safe() and use it everywhere Let's define two helpers strdupa_safe() + strndupa_safe() which do the same as their non-safe counterparts, except that they abort if called with allocations larger than ALLOCA_MAX. This should ensure that all our alloca() based allocations are subject to this limit. afaics glibc offers three alloca() based APIs: alloca() itself, strndupa() + strdupa(). With this we have now replacements for all of them, that take the limit into account. --- src/timedate/timedatectl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/timedate') diff --git a/src/timedate/timedatectl.c b/src/timedate/timedatectl.c index 6a4bbdbb48..d9767ba564 100644 --- a/src/timedate/timedatectl.c +++ b/src/timedate/timedatectl.c @@ -77,7 +77,7 @@ static int print_status_info(const StatusInfo *i) { /* Save the old $TZ */ tz = getenv("TZ"); if (tz) - old_tz = strdupa(tz); + old_tz = strdupa_safe(tz); /* Set the new $TZ */ tz_colon = strjoina(":", isempty(i->timezone) ? "UTC" : i->timezone); -- cgit v1.2.1