From 254d1313ae5a69c08c9b93032aaaf3d6083cfc07 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Mon, 19 Dec 2022 13:07:42 +0100 Subject: tree-wide: use -EBADF for fd initialization -1 was used everywhere, but -EBADF or -EBADFD started being used in various places. Let's make things consistent in the new style. Note that there are two candidates: EBADF 9 Bad file descriptor EBADFD 77 File descriptor in bad state Since we're initializating the fd, we're just assigning a value that means "no fd yet", so it's just a bad file descriptor, and the first errno fits better. If instead we had a valid file descriptor that became invalid because of some operation or state change, the other errno would fit better. In some places, initialization is dropped if unnecessary. --- src/udev/scsi_id/scsi_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/udev/scsi_id/scsi_serial.c') diff --git a/src/udev/scsi_id/scsi_serial.c b/src/udev/scsi_id/scsi_serial.c index f1ce8601bd..c619506877 100644 --- a/src/udev/scsi_id/scsi_serial.c +++ b/src/udev/scsi_id/scsi_serial.c @@ -786,7 +786,7 @@ out: int scsi_get_serial(struct scsi_id_device *dev_scsi, const char *devname, int page_code, int len) { unsigned char page0[SCSI_INQ_BUFF_LEN]; - int fd = -1; + int fd = -EBADF; int cnt; int ind; int retval; -- cgit v1.2.1