From c4a090d60e09cd85a56ff91c46ca0f7b22dcd1a8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Fri, 5 May 2023 09:03:12 +0200 Subject: Rewrite check-includes.pl in python --- tools/check-includes.pl | 23 ----------------------- tools/check-includes.py | 23 +++++++++++++++++++++++ 2 files changed, 23 insertions(+), 23 deletions(-) delete mode 100755 tools/check-includes.pl create mode 100755 tools/check-includes.py (limited to 'tools') diff --git a/tools/check-includes.pl b/tools/check-includes.pl deleted file mode 100755 index c8bfcba8c0..0000000000 --- a/tools/check-includes.pl +++ /dev/null @@ -1,23 +0,0 @@ -# SPDX-License-Identifier: CC0-1.0 -#!/usr/bin/env perl -# -# checkincludes: Find files included more than once in (other) files. - -foreach $file (@ARGV) { - open(FILE, $file) or die "Cannot open $file: $!.\n"; - - my %includedfiles = (); - - while () { - if (m/^\s*#\s*include\s*[<"](\S*)[>"]/o) { - ++$includedfiles{$1}; - } - } - foreach $filename (keys %includedfiles) { - if ($includedfiles{$filename} > 1) { - print "$file: $filename is included more than once.\n"; - } - } - - close(FILE); -} diff --git a/tools/check-includes.py b/tools/check-includes.py new file mode 100755 index 0000000000..27d11b9d0a --- /dev/null +++ b/tools/check-includes.py @@ -0,0 +1,23 @@ +#!/usr/bin/env python3 +# SPDX-License-Identifier: LGPL-2.1-or-later + +# pylint: disable=missing-docstring,invalid-name,unspecified-encoding,consider-using-with + +import re +import sys + +def check_file(filename): + seen = set() + good = True + for n, line in enumerate(open(filename)): + if m := re.match(r'^\s*#\s*include\s*[<"](\S*)[>"]', line): + include = m.group(1) + if include in seen: + print(f'{filename}:{n}: {line.strip()}') + good = False + seen.add(include) + return good + +if __name__ == '__main__': + good = all(check_file(name) for name in sys.argv[1:]) + sys.exit(0 if good else 1) -- cgit v1.2.1