From abc8c2d61c65757011d9d32abb01cd1e51232f3a Mon Sep 17 00:00:00 2001 From: Francois-Xavier Le Bail Date: Sat, 5 Sep 2020 19:40:32 +0200 Subject: Remove many (762) now redundant ND_TCHECK_n() calls ND_TCHECK_n(e), n in { 1, 2, 3, 4, 8 }. They are redundant because they are followed by a GET_.*_n(e) call, same n, same e, which do the bounds check. Remove unused 'trunc' labels and most associated codes. Update the outputs of some tests accordingly. --- print-loopback.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'print-loopback.c') diff --git a/print-loopback.c b/print-loopback.c index 07fbcbdd..a90c293b 100644 --- a/print-loopback.c +++ b/print-loopback.c @@ -61,7 +61,6 @@ loopback_message_print(netdissect_options *ndo, const u_char *cp, const u_int le if (len < 2) goto invalid; /* function */ - ND_TCHECK_2(cp); function = GET_LE_U_2(cp); cp += 2; ND_PRINT(", %s", tok2str(fcode_str, " invalid (%u)", function)); @@ -71,7 +70,6 @@ loopback_message_print(netdissect_options *ndo, const u_char *cp, const u_int le if (len < 4) goto invalid; /* receipt number */ - ND_TCHECK_2(cp); ND_PRINT(", receipt number %u", GET_LE_U_2(cp)); cp += 2; /* data */ @@ -114,7 +112,6 @@ loopback_print(netdissect_options *ndo, const u_char *cp, const u_int len) if (len < 2) goto invalid; /* skipCount */ - ND_TCHECK_2(cp); skipCount = GET_LE_U_2(cp); cp += 2; ND_PRINT(", skipCount %u", skipCount); -- cgit v1.2.1