From cfa9ab5f80dd9a1024e1a765bc0d24c57652b6bc Mon Sep 17 00:00:00 2001 From: Denis Ovsienko Date: Sun, 17 Jan 2021 23:11:19 +0000 Subject: Try the new ND_LCHECK*() macros. [skip ci] --- print-udp.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to 'print-udp.c') diff --git a/print-udp.c b/print-udp.c index b315f1e7..fc0710d6 100644 --- a/print-udp.c +++ b/print-udp.c @@ -369,10 +369,7 @@ udp_print(netdissect_options *ndo, const u_char *bp, u_int length, if (ndo->ndo_packettype != PT_RPC) udpipaddr_print(ndo, ip, sport, dport); - if (length < sizeof(struct udphdr)) { - ND_PRINT("undersized-udp %u", length); - goto invalid; - } + ND_LCHECKMSG_ZU(length, sizeof(struct udphdr), "undersized-udp"); ulen = GET_BE_U_2(up->uh_ulen); udp_sum = GET_BE_U_2(up->uh_sum); /* @@ -382,10 +379,7 @@ udp_print(netdissect_options *ndo, const u_char *bp, u_int length, */ if (ulen == 0 && length > 65535) ulen = length; - if (ulen < sizeof(struct udphdr)) { - ND_PRINT("undersized-udplength %u", ulen); - goto invalid; - } + ND_LCHECKMSG_ZU(ulen, sizeof(struct udphdr), "undersized-udplength"); ulen -= sizeof(struct udphdr); length -= sizeof(struct udphdr); if (ulen < length) -- cgit v1.2.1