diff options
| author | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2014-04-11 12:56:29 +0100 |
|---|---|---|
| committer | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2014-05-07 09:43:42 +0100 |
| commit | f48102b928c96567376dfd999e6dbd8b958bbf81 (patch) | |
| tree | 1747172a7d37161cde6c15e2c21e610fce652a6e | |
| parent | 88a654b97506963e03087885cf8645d87a89cf61 (diff) | |
| download | telepathy-glib-f48102b928c96567376dfd999e6dbd8b958bbf81.tar.gz | |
tp_base_connection_change_status: emit status-changed before StatusChanged
Gabble's regression tests expect to receive PresencesChanged before
StatusChanged, and PresencesChanged is triggered by the status-changed
GObject signal.
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=77189
| -rw-r--r-- | telepathy-glib/base-connection.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/telepathy-glib/base-connection.c b/telepathy-glib/base-connection.c index 2e85e64d0..7c02a7c13 100644 --- a/telepathy-glib/base-connection.c +++ b/telepathy-glib/base-connection.c @@ -1939,9 +1939,12 @@ tp_base_connection_change_status (TpBaseConnection *self, DEBUG("emitting status-changed to %u, for reason %u", status, reason); _tp_gdbus_connection_set_status (self->priv->connection_skeleton, status); + /* Emit status-changed before sending the D-Bus signal, because in practice + * that's what happened in telepathy-glib 0.x, as demonstrated by Gabble's + * regression tests failing otherwise. */ + g_signal_emit (self, signals[STATUS_CHANGED], 0, status, reason); _tp_gdbus_connection_emit_status_changed (self->priv->connection_skeleton, status, reason); - g_signal_emit (self, signals[STATUS_CHANGED], 0, status, reason); /* tell subclass about the state change. In the case of * disconnection, shut down afterwards */ |