diff options
| author | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 14:08:45 +0100 |
|---|---|---|
| committer | Xavier Claessens <xclaesse@gmail.com> | 2011-11-16 14:36:51 +0100 |
| commit | 67bffca0678d1286d07b1531f6562126e92cc31e (patch) | |
| tree | 309fa93328b63d8c1a90432bc1c697b4a97beba0 /telepathy-glib/text-mixin.c | |
| parent | e6d8b4c7531688cd2dbd3c9bbd8a6c224123de05 (diff) | |
| download | telepathy-glib-67bffca0678d1286d07b1531f6562126e92cc31e.tar.gz | |
Use _unref instead of _free _destroy when possible.
Replace g_(ptr_)array_free (foo, TRUE) and g_hash_table_destroy
with respectively g_(ptr_)array_unref (foo) and g_hash_table_unref.
I used this command to generate this patch:
for f in `find -name "*.c"`; do sed -i $f -re 's/g_ptr_array_free \(([^ ,]+), TRUE\)/g_ptr_array_unref \(\1\)/'; done
See Danielle's blog for explanation of possible bug _free can do:
http://blogs.gnome.org/danni/2011/11/16/mistakes-with-g_value_set_boxed/
Diffstat (limited to 'telepathy-glib/text-mixin.c')
| -rw-r--r-- | telepathy-glib/text-mixin.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/telepathy-glib/text-mixin.c b/telepathy-glib/text-mixin.c index cd0980a32..b93b76f4c 100644 --- a/telepathy-glib/text-mixin.c +++ b/telepathy-glib/text-mixin.c @@ -262,7 +262,7 @@ tp_text_mixin_finalize (GObject *obj) g_queue_free (mixin->priv->pending); - g_array_free (mixin->priv->msg_types, TRUE); + g_array_unref (mixin->priv->msg_types); g_slice_free (TpTextMixinPrivate, mixin->priv); } @@ -536,7 +536,7 @@ tp_text_mixin_list_pending_messages_async (TpSvcChannelTypeText *iface, for (i = 0; i < ret->len; i++) g_value_array_free (g_ptr_array_index (ret, i)); - g_ptr_array_free (ret, TRUE); + g_ptr_array_unref (ret); } else { |