summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* early return if GetContactInfo() failedtelepathy-glib-0.16Guillaume Desmottes2012-02-221-0/+1
| | | | https://bugs.freedesktop.org/show_bug.cgi?id=46430
* set nano flagGuillaume Desmottes2012-02-131-1/+1
|
* prepare 0.16.5telepathy-glib-0.16.5Guillaume Desmottes2012-02-132-3/+14
|
* make sure the result object stays alive while renaming groupsGuillaume Desmottes2012-02-131-3/+7
| | | | | | I started tracking this in Gabble so my unit test is living there. https://bugs.freedesktop.org/show_bug.cgi?id=45982
* NEWS for 0.16Simon McVittie2012-02-091-0/+8
|
* TpSimplePasswordManager: copy the string into the resultSimon McVittie2012-02-091-1/+7
| | | | | | | | | | Otherwise, if a caller kept a ref to the GAsyncResult after control had returned to the channel, the channel could have freed the GString already. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45554 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* tp_account_update_parameters_async: fix lifetime of result, and test itSimon McVittie2012-02-093-2/+73
| | | | | | | | | | | | | | Without this change to TpAccount, the test would fail with a use-after-free while inspecting reconnect_required. The TpAccount code assumed that _finish would always be called directly from the callback, but it is perfectly valid not to do so. In the test, also test Reconnect (which is currently unimplemented), since UpdateParameters and Reconnect are so closely related. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45554 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* tp_account_manager_create_account_finish: warn that the return has a limited ↵Simon McVittie2012-02-091-1/+1
| | | | | | | | lifetime Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45554 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* account test: deliberately keep async results after the callbackSimon McVittie2012-02-091-24/+46
| | | | | | | | | This is valid usage, and often (as in this case!) uncovers bugs. It also makes the flow of the code more obvious. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45554 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* TpAccount: ensure that async-returned objects live as long as the resultSimon McVittie2012-02-091-7/+13
| | | | | | | | | | | | It is valid to keep a GAsyncResult for as long as you like, so it will have to take a copy of the result data. Otherwise, a change as simple as replacing g_simple_async_result_complete with ..._complete_in_idle will result in the data having already been freed by the time the caller sees it. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45554 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* TpTestsSimpleAccount: add Avatar interfaceSimon McVittie2012-02-091-1/+36
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=45554 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* channel-request test: avoid a race conditionSimon McVittie2012-02-021-0/+6
| | | | | | | | | | If we emit Succeeded or Failed quickly enough after setting up the TpProxy, the match rules might not have reached the dbus-daemon yet. (The real ChannelRequest implementation avoids this bug by having the Proceed method.) Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* channel-contacts.c: Fix crash when preparing TpCallChannelXavier Claessens2012-02-022-11/+15
| | | | | | | | | | | If if a new contact fetch is queued from the callback of last contact fetch, it leads to a crash. This is because when queueing the new item it is processed right away since it is the only item in queue, then when it returns from g_simple_async_result_complete() it calls process_contacts_queue() again so the item is prepared twice, and then freed twice. Fix this by keeping currently being processes item outside the queue.
* get_most_available_presence(): match the doc if no account connectedGuillaume Desmottes2012-01-241-3/+3
| | | | | | If no account is connected, doc says we should return (TP_CONNECTION_PRESENCE_TYPE_OFFLINE, "offline", "") but we use to return (TP_CONNECTION_PRESENCE_TYPE_OFFLINE, NULL, NULL)
* TpSimple{Observer, Approver, Handler}: Do not use deprecated API doc examplesXavier Claessens2011-12-133-5/+11
|
* set nano flagGuillaume Desmottes2011-12-131-1/+1
|
* prepare 0.16.4telepathy-glib-0.16.4Guillaume Desmottes2011-12-132-2/+13
|
* handle_owners_changed_prepared_cb: use a NULL safe g_object_refGuillaume Desmottes2011-12-131-1/+10
| | | | | | An unknown owner is implemented storing a NULL TpContact in the hash table. https://bugs.freedesktop.org/show_bug.cgi?id=43755
* tp_account_set_uri_scheme_association_async: set the right source tagGuillaume Desmottes2011-12-071-1/+1
| | | | | Convention is to use the _async method as that's what being checked in tp_account_set_uri_scheme_association_finish().
* Remove ; that should not beDanielle Madeley2011-11-281-1/+1
|
* set nano flagGuillaume Desmottes2011-11-281-1/+1
|
* prepare 0.16.3telepathy-glib-0.16.3Guillaume Desmottes2011-11-282-3/+17
|
* configure: bump gobject-introspect dep to 1.30Will Thompson2011-11-111-1/+1
| | | | | | | Sjoerd tells me that “with older g-i you don't get all annotation right and gnome-shell will fail”. Specifically, methods like DelegateChannel(), used by Gnome Shell 3.2, don't work. 1.30 is the current stable release.
* Bump the Vala requirement to fix binding for ContactInfoFieldTravis Reitter2011-11-111-1/+1
| | | | | | | | | | | | Vala-0.12 does not generate the constructor for ContactInfoField, which causes a build failure for Folks (and any other clients that depend upon creating new ContactInfoFields from Vala). Empathy 3.2, for whose benefit the 0.16 stable branch of tp-glib exists, depends (via Folks) on telepathy-glib being built with at least valac-0.14. https://bugs.freedesktop.org/show_bug.cgi?id=42296
* TpSimplePasswordManager: don't keep a pointer to the challenge resultMikhail Zabaluev2011-11-081-4/+1
| | | | | The pointer goes stale when the result is consumed, and it trips an assertion if the manager gets a new challenge.
* set nano flagGuillaume Desmottes2011-11-081-1/+1
|
* prepare 0.16.2telepathy-glib-0.16.2Guillaume Desmottes2011-11-082-3/+18
|
* channel-contacts: hash table may contain NULL contactGuillaume Desmottes2011-11-071-1/+6
| | | | | | | This is the case when joining a room containing members having an unknown owner. https://bugs.freedesktop.org/show_bug.cgi?id=42670
* don't call _tp_contacts_to_handles in g_return_if_failGuillaume Desmottes2011-10-311-4/+10
| | | | | g_return_if_fail() can be compiled as noop, so we shouldn't rely on it to get the handles.
* group-mixin: always set the Members_Changed_Detailed flagGuillaume Desmottes2011-10-312-4/+11
| | | | | | | We unconditionally implements the MembersChangedDetailed signal so this flag should always be set. https://bugs.freedesktop.org/show_bug.cgi?id=42305
* Document the meaning of TpProxy::invalidatedDanielle Madeley2011-10-311-0/+8
| | | | | It turns out that when we talked about invalidation, people didn't actually know what this meant.
* set nano versionGuillaume Desmottes2011-10-251-1/+1
|
* prepare 0.16.1telepathy-glib-0.16.1Guillaume Desmottes2011-10-242-4/+16
|
* document capabilities_queueGuillaume Desmottes2011-10-241-0/+2
|
* Prevent circular introspection dependencySjoerd Simons2011-10-241-20/+21
| | | | | | | | | | | | As part of preparing a Connection the self contact will be retrieved. If the contacts requested features include _CAPABILITIES _and_ the connection doesn't support ContactCapabilities then the Capabilties of the connection get use. But if we wait for this feature to be prepared then the introspection stalls. So instead use internal API to force getting the capabilities of the connection regardless of the state of the various features and break the circular dependency.
* Add internal API to get connection capabilities without having core preparedSjoerd Simons2011-10-242-8/+72
|
* Let TpTestsNoRequestsConnection return an empty RCCSjoerd Simons2011-10-241-1/+4
| | | | | | | If we don't implement Requests we shouldn't respond to the retrieval of RCC properties. Unfortunately that's tricky to do, so do a quick hack which means we will have an empty RCC property, which is at least somewhat more useful for our tests.
* Make it easier to debug connection preparation by printing object paths in ↵Sjoerd Simons2011-10-241-3/+4
| | | | some cases
* Add some extra debugging to make it easier to follow AccountManager preparationSjoerd Simons2011-10-241-0/+5
|
* base-contact-list: implement ↵Guillaume Desmottes2011-10-202-0/+85
| | | | | | TP_TOKEN_CONNECTION_INTERFACE_CONTACT_BLOCKING_BLOCKED https://bugs.freedesktop.org/show_bug.cgi?id=42049
* deal with self->priv->group_contact_owners may containing NULL contactGuillaume Desmottes2011-10-182-1/+13
| | | | | | | | If the owner is unknown self->priv->group_contact_owners may contain NULL TpContact. g_object_unref() not being NULL safe we have to use our own value_destroy_func to avoid warnings. https://bugs.freedesktop.org/show_bug.cgi?id=41928
* test_receive_muc_delivery: use g_test_bug()Guillaume Desmottes2011-10-181-1/+2
|
* _tp_channel_contacts_queue_prepare_finish: don't assume item->contacts is ↵Guillaume Desmottes2011-10-182-1/+53
| | | | | | | | | not NULL For example, when receiving a MUC delivery report we end up with a message having no sender and so no contact to prepare. https://bugs.freedesktop.org/show_bug.cgi?id=41929
* Bump nano-version to 0.16.1.1Will Thompson2011-10-142-1/+6
|
* Version 0.16.0telepathy-glib-0.16.0Will Thompson2011-10-142-6/+6
|
* Truncate generated ChangeLog at 0.12.0Will Thompson2011-10-141-1/+1
|
* NEWS for 0.16.0Will Thompson2011-10-141-2/+32
|
* Account: expand :normalized-name documentation.Will Thompson2011-10-141-1/+3
| | | | Fixes: <https://bugs.freedesktop.org/show_bug.cgi?id=41714>
* test-channel-introspect: remove most MYASSERTsWill Thompson2011-10-141-45/+28
| | | | | | | | | This macro is really ugly. I only left it in place for assertions like MYASSERT (!tp_proxy_prepare_finish (chan, prepare_result, &error), ""); where the assertion has a side-effect. Otherwise, if someone disables assertions the test will crash. Ugh.
* test-channel-introspect: plug a leakWill Thompson2011-10-141-0/+3
| | | | fea8294 introduced this pretty obvious leak.