| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
glib 2.39.0 started to print a g_critical() message when calling
g_source_remove() on a source that does not exist anymore.
|
| |
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69849
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54500
|
| |
|
|
|
|
|
|
|
|
| |
A GCompareFunc might return any negative or positive value if the two
values are not equal.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68932
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| |
|
|
|
|
|
| |
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Many connection managers automatically exit after 5 seconds of
inactivity. If the CM has no .manager file *and* exits in this way
while we are introspecting it, we would previously consider it to have
failed introspection - but with sufficiently unfortunate timing,
that can result in empathy-accounts not considering Haze to exist.
To avoid this, without going into an infinite loop if the CM fails to
introspect, retry once, but only once.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67183
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=46430
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
This makes it possible to run the tool tests under the Automake 1.12+
parallel test harness, which is the default from 1.13 onwards.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65517
|
| |
|
|
|
|
|
|
|
| |
We shouldn't assert if the CM is broken.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=61616
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|
|
|
|
|
| |
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=52011
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We already announced each group from tp_base_contact_list_groups_created
a few lines ago; we don't need to do it again.
Ideally we'd add each channel's members before announcing the
channel itself, so that the channel is created "fully-formed"; but
we've never actually done that, and keeping the first NewChannels
instead of the second seems less likely to break applications.
These channels are only for legacy code anyway: any modern client
should be using the ContactGroups interface.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=52011
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Returning a GPtrArray with (transfer full) means the caller is expected
to do the equivalent of:
g_ptr_array_foreach (pa, (GFunc) g_free, NULL);
g_ptr_array_unref (pa);
whereas we just want them to unref it. This crashed my g-i-based
debug-client.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65518
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
| |
Fixes fdo#64837
|
| |
|
|
|
|
| |
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=61254
|
|
|
|
|
|
|
| |
kuuko discovered that unset_parameters is wrongly inferred to be a
string argument, not a string array argument. At runtime, passing a
string crashes. I think this is a bug in gobject-introspection but we
can annotate it as an array to fix this particular function.
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
telepathy-glib prefers to use DBUS_BUS_STARTER, for the benefit of
Telepathy components that are (or might be) service-activatable.
The actual terminal part of gnome-terminal 3.8 is an activatable service,
so when run from there, we pick up the real session bus' address via
DBUS_STARTER_ADDRESS. We don't want that.
(Yes, it's DBUS_STARTER_ADDRESS, not DBUS_STARTER_BUS_ADDRESS. The
reference implementation and the D-Bus Specification both say so.)
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63119
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
| |
|
| |
|
|
|
|
|
|
| |
Older GLib explicitly disallowed non-characters (as this test assumes)
but newer GLib follows Unicode Corrigendum 9 and allows them.
https://bugzilla.gnome.org/show_bug.cgi?id=694669
|
|
|
|
|
|
| |
Signed-off-by: Maksim Melnikau <maxposedon@gmail.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=62968
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| |
|
| |
|
| |
|
|\
| |
| |
| |
| | |
Conflicts:
NEWS
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| | |
In Automake 1.13, the long-deprecated macro AM_CONFIG_HEADER (deprecated
since 2002) has been removed in favour of AC_CONFIG_HEADERS.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=59604
|
| |
| |
| |
| |
| | |
tp_connection_get_contact_by_id_async does not exist; it is called
tp_connection_dup_contact_by_id_async.
|
|\ \
| |/
| |
| |
| | |
Conflicts:
NEWS
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
tp_simple_client_factory_ensure_contact returns NULL for protocols, if
tp_connection_has_immortal_handles=0. Right now its happened for any
telepathy-python based protocols (butterfly, sunsine, mixer).
when tp_simple_client_factory_ensure_contact returns NULL,
tp_simple_client_factory_ensure_contact just segfault in
_tp_contact_set_attributes.
lets assume that contact sometimes NULL here, and skip them
Signed-off-by: Maksim Melnikau <maxposedon@gmail.com>
[edited for coding style, added a comment -smcv]
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Correctly get the remote contact handle out of the MediaDescription
hash, it's an a{sv} not string => uint32.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54425
Conflicts:
telepathy-glib/base-media-call-content.c
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Remove the code that errors out a local description update if there is
*any* outstanding offer. A bit later in the same function a proper check
is done to see if there is a offer for the update contact, which is
correct.
Conflicts:
telepathy-glib/base-media-call-content.c
|
| | |
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This fixes compilation with --enable-introspection when introspection
warnings are treated as errors.
Signed-off-by: Robert McQueen <robert.mcqueen@collabora.co.uk>
https://bugs.freedesktop.org/show_bug.cgi?id=58851
|
| | |
|
| | |
|
| | |
|