| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
| |
| |
| |
| | |
https://bugs.freedesktop.org/show_bug.cgi?id=50886
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Those constructors are useless because TpChannelRequest and
TpChannelDispatchOperation objects are created internally by
TpBaseClient and friends. Applications using the high-level API
should never need them.
Those constructors are harmful because they do not take a factory and
they need a factory internally. This means that creating our own
TpChannelRequest/TpChannelDispatchOperation will create our own
account/connection/channel/whatever objects instead of sharing them.
Internally we already have _new_with_factory() variant.
https://bugs.freedesktop.org/show_bug.cgi?id=49372
|
| |
| |
| |
| |
| |
| |
| | |
Headers to use is caller's choice, like that tp-glib internal can use
single headers while extensions can use global header.
This also move command line headers to generated .h instead of .c
|
| | |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Most of it is useless in non-C languages, so we (skip) it. However,
tp_simple_async_report_success_in_idle(), tp_utf8_make_valid(),
tp_escape_as_identifier() and the user-action-time functions all
seem like useful things to have.
The tp_g_value_slice_new() family confuses g-ir-scanner (which goes
looking for a TpGValueSlice type), but they're all (skip)'d anyway,
so #ifdef them out.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54543
|
| |
| |
| |
| |
| |
| | |
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
|
| |
| |
| |
| |
| |
| |
| |
| | |
by _dup_
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
|
| |
| |
| |
| |
| |
| |
| |
| | |
by _dup_
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
|
| |
| |
| |
| |
| |
| |
| |
| | |
them by _dup_
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
|
| |
| |
| |
| |
| |
| |
| |
| | |
replace them by _dup_
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
|
| |
| |
| |
| |
| |
| |
| |
| | |
by _dup_
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
There is intentionally no tp_protocol_get_params() because it is internally
an unintrospectable C-array, so a proper container needs to be created. In
next branch they are internally in a GPtrArray so a _get_ function could
be added.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
There is intentionally no tp_dispatch_operation_get_immutable_properties()
since those are internal implementation detail. Individual property getters
should be enough.
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
_tp_channel_get_immutable_properties() is kept internal because we don't
want to expose more dbus-glib structures. tp_channel_dup_immutable_properties()
is added, it returns a GVariant and should be needed only to TpChannel
subclasses.
|
| |
| |
| |
| |
| |
| | |
New transfer and naming policy has been discussed in
https://bugs.freedesktop.org/show_bug.cgi?id=39189 and is
documented there: http://telepathy.freedesktop.org/wiki/Style/TelepathyGLib
|
| |
| |
| |
| | |
We can use g_list_free_full and (_tp_)g_list_copy_deep in more places
|
| |
| |
| |
| |
| |
| | |
This implementation is less optimized than g_list_copy_deep() because it
iterates the list twice. But it will be removed once we depend on
glib 2.34
|
| |
| |
| |
| |
| |
| |
| |
| | |
Correctly get the remote contact handle out of the MediaDescription
hash, it's an a{sv} not string => uint32.
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54425
|
| |
| |
| |
| |
| |
| |
| | |
Remove the code that errors out a local description update if there is
*any* outstanding offer. A bit later in the same function a proper check
is done to see if there is a offer for the update contact, which is
correct.
|
| | |
|
| |
| |
| |
| |
| |
| |
| | |
When ObserveChannels comes in we are given all the immutable properties
for the statisfied requests straight away, so lets use them as well.
This prevents poor application authors from being confused about their
hints not coming through in their observer.
|
| |
| |
| |
| |
| |
| |
| | |
When HandleChannels comes in we are given all the immutable properties
for the statisfied requests straight away, so lets use them as well.
This prevents poor application authors from being confused about their
hints not coming through in their handler.
|
| |
| |
| |
| |
| | |
And an easy and bindable API to add a single hint to the hints
dictionary
|
| |
| |
| |
| | |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|\ \ |
|
| | |
| | |
| | |
| | | |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
N1570 (C11 final draft) §6.7.3 says this usage is valid[1] so modern
gcc doesn't have an option to even warn about it, but this is a recent
change to the C standard, and older compilers like the one in the
Android NDK treat it as a fatal error.
[1] "a typedef name may be redefined to denote the same
type as it currently does, provided that type is not a variably
modified type"
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=53100
Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | |
| | |
| | |
| | |
| | |
| | | |
being NULL
https://bugs.freedesktop.org/show_bug.cgi?id=53201
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
When creating/editing an account, the Ubuntu Online Accounts panel loads the
relevant plugin dynamically. In order to work properly, this plugin has to
define the default AM with some features. But
tp_account_manager_set_default() can only be called once, later calls
resulting in critical warnings. By using tp_account_manager_can_set_default()
the plugin can check if the default AM has already be defined or not.
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
If the subclass sets the channel's target handle, then it had better set
the target handle type in the klass. I got this wrong when porting Idle
to TpBaseChannel.
Fist-bumped-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Very occasionally, a parallel build will fail like this:
| Making all in telepathy-glib
| make[2]: Entering directory `/buildarea1/yocto-autobuilder/yocto-slave/nightly-x86/build/build/tmp/work/i586-poky-linux/telepathy-glib-0.19.2-r0/telepathy-glib-0.19.2/telepathy-glib'
| /bin/mkdir -p _gen
| ( cd . && cat versions/0.7.0.abi [...] versions/0.19.2.abi ) | \
| /bin/grep '^tp_cli_.*_run_.*' > _gen/reentrant-methods.list.tmp
| /bin/sh: line 1: _gen/reentrant-methods.list.tmp: No such file or directory
| make[2]: *** [_gen/reentrant-methods.list] Error 1
It's doing the mkdir and the subshell in parallel, when the mkdir should be done
first. Add an explicit dependency on spec-stamp to reentrant-methods.list to
ensure the ordering.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=52480
Reviwewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
Reviwewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|\ \ \
| | |/
| |/| |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
TpConnection itself wants to prepare TpContacts before being officially
CONNECTED. This was already the case for self contact. Use the same
trick for blocked contacts.
https://bugs.freedesktop.org/show_bug.cgi?id=52441
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Since we added async handle normalization functions, RequestHandles(1, [])
would just not return at all.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | | |
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
the struct
I already removed the padding (in c14d25b4bf4 and 436219789348) so
just re-arrange the struct.
D'oh.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
|\ \ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Conflicts:
telepathy-glib/base-connection-manager.c
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a lot like 74bd945252, but we're having to deal with another
older get_interfaces vfunc, which is slightly annoying.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Calling set_size on the GArray is a little overkill.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
gtk-doc gets confused, so they've been removed from the docs. See
also: e8f9a27a388e21
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a lot like 74bd945252.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | | |
| | | |
| | | |
| | | | |
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
This is a lot like 74bd945252.
Signed-off-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
|