| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68390
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
|
| |
|
|
|
|
|
|
|
| |
Based on patches by Luca Versari and Chandni Verma.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63402
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
|
|
|
|
| |
https://bugs.freedesktop.org/show_bug.cgi?id=69520
|
|
|
|
|
|
|
|
|
| |
There's no real reason not to - anything that implements D-Bus
properties is clearly going to have this method in some form.
Also, my next commit needs it.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69283
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
|
| |
Failure to do so causes a false-positive in Debian's build log checks,
which check that "hardening" flags are passed to all compilations.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65293
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On current Debian unstable, gcc/ld issues a warning about tmpnam(),
because it's usually used in an unsafe way. "gcc -Wl,--fatal-warnings"
(which I'm using in my development environment) upgrades that to fatal.
Our usage was in fact safe (trying to listen on a socket always
behaves like O_EXCL|O_CREAT, which can DoS'd but is not subject to
symlink attacks), but we're swimming against the current by trying
to use tmpnam(). Instead, create a secure private temporary directory
with g_dir_make_tmp(), and put our socket in there.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68350
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
tp_simple_client_factory_ensure_channel and
tp_simple_client_factory_ensure_contact already enforced that via a check,
but didn't document it.
tp_simple_client_factory_upgrade_contacts_async didn't previously
either document or enforce it, and strictly speaking there's no reason
why it shouldn't work, so I'm using a warning instead of a
critical-and-return - but it probably indicates an error, so I think
it should warn.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
| |
For most applications, the rule is "the account manager does that".
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
| |
TpConnection does much, much more than a simple D-Bus proxy now.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
|
| |
This text made sense before we implemented more stuff, but is
obsolete now.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
| |
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
It always has a factory, and if none is specified at construction,
the default is to use a TpAutomaticClientFactory. If we document
that, then client code won't need to mess about with
tp_account_manager_set_default() unless it has special requirements,
namely: either it has a factory of its own with more features and/or
subclasses, or a TpSimpleClientFactory is sufficient and low-overhead
is important.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|
|
|
|
|
|
|
| |
The documentation had fewer guarantees than the implementation: since
0.16, we've delayed notification of new accounts until they're prepared.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|\
| |
| |
| |
| | |
Conflicts:
NEWS
|
| |
| |
| |
| |
| |
| |
| |
| | |
A GCompareFunc might return any negative or positive value if the two
values are not equal.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68932
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
|\ \
| |/
| |
| |
| |
| | |
Conflicts:
NEWS
configure.ac
|
| |
| |
| |
| |
| | |
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Many connection managers automatically exit after 5 seconds of
inactivity. If the CM has no .manager file *and* exits in this way
while we are introspecting it, we would previously consider it to have
failed introspection - but with sufficiently unfortunate timing,
that can result in empathy-accounts not considering Haze to exist.
To avoid this, without going into an infinite loop if the CM fails to
introspect, retry once, but only once.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67183
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
| |
| |
| |
| | |
https://bugs.freedesktop.org/show_bug.cgi?id=46430
|
| |
| |
| |
| |
| | |
Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk>
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| |
| |
| |
| | |
https://bugs.freedesktop.org/show_bug.cgi?id=46430
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
TP_MEDIA_STREAM_STATE_DISCONNECTED is from another enum entirely,
and will no longer exist in Telepathy 1.0.
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65517
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This means we define MKDIR_P instead of mkdir_p - adjust.
Strictly speaking this requires Autoconf 2.59d, but 2.60 is hardly a
new innovation (it was released in 2006).
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65517
|
|\ \
| |/
| |
| |
| | |
Conflicts:
NEWS
|
| |
| |
| |
| |
| |
| |
| | |
We shouldn't assert if the CM is broken.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=61616
Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We already announced each group from tp_base_contact_list_groups_created
a few lines ago; we don't need to do it again.
Ideally we'd add each channel's members before announcing the
channel itself, so that the channel is created "fully-formed"; but
we've never actually done that, and keeping the first NewChannels
instead of the second seems less likely to break applications.
These channels are only for legacy code anyway: any modern client
should be using the ContactGroups interface.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=52011
Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
|
|\ \
| |/ |
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Returning a GPtrArray with (transfer full) means the caller is expected
to do the equivalent of:
g_ptr_array_foreach (pa, (GFunc) g_free, NULL);
g_ptr_array_unref (pa);
whereas we just want them to unref it. This crashed my g-i-based
debug-client.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65518
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
|
|\ \
| |/ |
|
| |
| |
| |
| | |
Fixes fdo#64837
|
|\ \
| |/
| |
| |
| | |
Conflicts:
NEWS
|
| |
| |
| |
| | |
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=61254
|
| |
| |
| |
| |
| |
| |
| | |
kuuko discovered that unset_parameters is wrongly inferred to be a
string argument, not a string array argument. At runtime, passing a
string crashes. I think this is a bug in gobject-introspection but we
can annotate it as an array to fix this particular function.
|
| | |
|
| | |
|
| |
| |
| |
| |
| | |
It is already explained in tp_connection_invalidated(), connection
must drop its refs to all TpContact at that point.
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|