summaryrefslogtreecommitdiff
path: root/telepathy-glib
Commit message (Collapse)AuthorAgeFilesLines
* fix file path leakstelepathy-glib-0.22Guillaume Desmottes2014-03-131-6/+14
| | | | | | g_file_get_path() returns (transfer full). Fix fdo#76119
* base-client: fix TpConnection leakGuillaume Desmottes2014-01-201-0/+3
|
* Merge branch 'telepathy-glib-0.20' into telepathy-glib-0.22Xavier Claessens2013-11-261-1/+2
|\
| * TpBaseConnectionManager: Fix critical printed each time a new connection is madetelepathy-glib-0.20Xavier Claessens2013-11-261-1/+2
| | | | | | | | | | glib 2.39.0 started to print a g_critical() message when calling g_source_remove() on a source that does not exist anymore.
* | channel-group: don't crash if no message has been providedGuillaume Desmottes2013-10-241-1/+1
| |
* | TpContact: avoid a race condition in avatar handlingSimon McVittie2013-10-021-5/+31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have to remember the avatar token synchronously, before we start async-saving the cached file, so that we can't get into this situation: my avatar is token "A", bytes "AAAA..." my avatar changes to token "B", bytes "BBBB..." we start saving the file /.../B my avatar changes to token "C", bytes "CCCC..." saving the file /.../B finishes change-notification announces that my avatar has changed to "B" which is particularly problematic for Mission Control. Regression in 0.21.2 (fd.o #63402). Bug: https://bugs.freedesktop.org/show_bug.cgi?id=70010 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | Merge branch 'telepathy-glib-0.20' into telepathy-glib-0.22Simon McVittie2013-09-261-0/+6
|\ \ | |/ | | | | | | Conflicts: NEWS
| * Account: don't crash if a CM returns a non-(ays) AvatarSimon McVittie2013-09-261-0/+6
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69849 Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
| * TpConnection: don't crash if a broken CM has no Groups propertySimon McVittie2013-09-261-1/+1
| | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54500
* | TpConnection: don't crash if a broken CM has no Groups propertySimon McVittie2013-09-241-1/+1
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54500 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpConnectionManager, TpProtocol: improve debug outputSimon McVittie2013-09-244-26/+125
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68390 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | add ABI file for 0.21.2Guillaume Desmottes2013-09-242-0/+8
| |
* | update UNRELEASEDGuillaume Desmottes2013-09-243-3/+3
| |
* | Make avatar image caching asynchronousSimon McVittie2013-09-241-34/+120
| | | | | | | | | | | | | | Based on patches by Luca Versari and Chandni Verma. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63402 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpBaseConnection: Implement SelfID and SelfContactChangedXavier Claessens2013-09-231-14/+46
| |
* | base-protocol: add Presence.Statuses as immutable propertiesGuillaume Desmottes2013-09-181-1/+5
| | | | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=69520
* | tp_dbus_properties_mixin_dup_all: make publicSimon McVittie2013-09-134-40/+9
| | | | | | | | | | | | | | | | | | There's no real reason not to - anything that implements D-Bus properties is clearly going to have this method in some form. Also, my next commit needs it. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69283 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | Pass on all AM_CPPFLAGS and CPPFLAGS to g-ir-scannerSimon McVittie2013-09-061-1/+3
| | | | | | | | | | | | | | | | Failure to do so causes a false-positive in Debian's build log checks, which check that "hardening" flags are passed to all compilations. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65293 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | _tp_create_temp_unix_socket: avoid using tmpnam()Simon McVittie2013-09-063-18/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | On current Debian unstable, gcc/ld issues a warning about tmpnam(), because it's usually used in an unsafe way. "gcc -Wl,--fatal-warnings" (which I'm using in my development environment) upgrades that to fatal. Our usage was in fact safe (trying to listen on a socket always behaves like O_EXCL|O_CREAT, which can DoS'd but is not subject to symlink attacks), but we're swimming against the current by trying to use tmpnam(). Instead, create a secure private temporary directory with g_dir_make_tmp(), and put our socket in there. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68350 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpSimpleClientFactory: drop doc-comments for private functionsSimon McVittie2013-09-061-4/+4
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpSimpleClientFactory: document "connection must be ours"Simon McVittie2013-09-061-3/+7
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | tp_simple_client_factory_ensure_channel and tp_simple_client_factory_ensure_contact already enforced that via a check, but didn't document it. tp_simple_client_factory_upgrade_contacts_async didn't previously either document or enforce it, and strictly speaking there's no reason why it shouldn't work, so I'm using a warning instead of a critical-and-return - but it probably indicates an error, so I think it should warn. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpConnection: don't recommend that applications call Connect()Simon McVittie2013-09-061-2/+6
| | | | | | | | | | | | | | For most applications, the rule is "the account manager does that". Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpConnection: describe factory behaviourSimon McVittie2013-09-061-0/+8
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpCDO, TpChannelRequest: always has a factorySimon McVittie2013-09-062-0/+8
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpCDO, TpChannelRequest: mention that they should come from "larger" objectsSimon McVittie2013-09-062-0/+7
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpSimpleClientFactory: suggest getting objects from "larger" objectsSimon McVittie2013-09-061-1/+13
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpConnection: connections should come from accountsSimon McVittie2013-09-061-0/+4
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpConnection: remove woefully outdated feature listSimon McVittie2013-09-061-8/+0
| | | | | | | | | | | | | | TpConnection does much, much more than a simple D-Bus proxy now. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpChannelDispatchOperation, TpChannelRequest: remove boilerplateSimon McVittie2013-09-062-13/+0
| | | | | | | | | | | | | | | | This text made sense before we implemented more stuff, but is obsolete now. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpAccount: document interaction with factories a bit betterSimon McVittie2013-09-061-3/+11
| | | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpAccountManager: tighten up guarantees about factoriesSimon McVittie2013-09-061-16/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | It always has a factory, and if none is specified at construction, the default is to use a TpAutomaticClientFactory. If we document that, then client code won't need to mess about with tp_account_manager_set_default() unless it has special requirements, namely: either it has a factory of its own with more features and/or subclasses, or a TpSimpleClientFactory is sufficient and low-overhead is important. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | TpAccountManager: fix documentation of how many accounts are preparedSimon McVittie2013-09-061-9/+4
| | | | | | | | | | | | | | | | The documentation had fewer guarantees than the implementation: since 0.16, we've delayed notification of new accounts until they're prepared. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54061 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | Merge branch 'telepathy-glib-0.20'Simon McVittie2013-09-041-4/+4
|\ \ | |/ | | | | | | Conflicts: NEWS
| * TpHeap: comparator results are not guaranteed to be -1, 0 and 1Debarshi Ray2013-09-041-4/+4
| | | | | | | | | | | | | | | | A GCompareFunc might return any negative or positive value if the two values are not equal. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68932 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* | Merge branch 'telepathy-glib-0.20'Simon McVittie2013-08-201-3/+26
|\ \ | |/ | | | | | | | | Conflicts: NEWS configure.ac
| * Fix documentation for tp_connection_get_self_handleEmilio Pozuelo Monfort2013-08-191-1/+1
| | | | | | | | | | Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| * TpConnectionManager: retry introspection after CM exits, up to onceSimon McVittie2013-07-241-3/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Many connection managers automatically exit after 5 seconds of inactivity. If the CM has no .manager file *and* exits in this way while we are introspecting it, we would previously consider it to have failed introspection - but with sufficiently unfortunate timing, that can result in empathy-accounts not considering Haze to exist. To avoid this, without going into an infinite loop if the CM fails to introspect, retry once, but only once. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=67183 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
| * early return if GetContactInfo() failedGuillaume Desmottes2013-07-171-0/+1
| | | | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=46430
* | Fix documentation for tp_connection_get_self_handleEmilio Pozuelo Monfort2013-08-191-1/+1
| | | | | | | | | | Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo@collabora.co.uk> Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* | early return if GetContactInfo() failedGuillaume Desmottes2013-07-171-0/+1
| | | | | | | | https://bugs.freedesktop.org/show_bug.cgi?id=46430
* | tp_call_stream_endpoint_get_state: return a TpStreamEndpointState on errorSimon McVittie2013-06-111-1/+1
| | | | | | | | | | | | | | | | | | TP_MEDIA_STREAM_STATE_DISCONNECTED is from another enum entirely, and will no longer exist in Telepathy 1.0. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65517
* | Use AC_PROG_MKDIR_P instead of deprecated AM_PROG_MKDIR_PSimon McVittie2013-06-112-2/+2
| | | | | | | | | | | | | | | | | | | | This means we define MKDIR_P instead of mkdir_p - adjust. Strictly speaking this requires Autoconf 2.59d, but 2.60 is hardly a new innovation (it was released in 2006). Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65517
* | Merge branch 'telepathy-glib-0.20'Simon McVittie2013-06-101-1/+12
|\ \ | |/ | | | | | | Conflicts: NEWS
| * tls-certificate: invalidate the proxy if CertificateChainData is missingGuillaume Desmottes2013-06-101-1/+12
| | | | | | | | | | | | | | We shouldn't assert if the CM is broken. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=61616 Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| * tp_base_contact_list_set_list_received: don't re-announce groupsSimon McVittie2013-06-101-7/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We already announced each group from tp_base_contact_list_groups_created a few lines ago; we don't need to do it again. Ideally we'd add each channel's members before announcing the channel itself, so that the channel is created "fully-formed"; but we've never actually done that, and keeping the first NewChannels instead of the second seems less likely to break applications. These channels are only for legacy code anyway: any modern client should be using the ContactGroups interface. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=52011 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
* | Merge branch 'telepathy-glib-0.20'Simon McVittie2013-06-101-2/+2
|\ \ | |/
| * tp_debug_client_get_messages_finish: fix annotationSimon McVittie2013-06-101-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Returning a GPtrArray with (transfer full) means the caller is expected to do the equivalent of: g_ptr_array_foreach (pa, (GFunc) g_free, NULL); g_ptr_array_unref (pa); whereas we just want them to unref it. This crashed my g-i-based debug-client. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=65518 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* | Merge branch 'telepathy-glib-0.20'Xavier Claessens2013-05-221-2/+1
|\ \ | |/
| * TpCallStream: Fix local-sending-state-changed signal signature.Xavier Claessens2013-05-221-2/+1
| | | | | | | | Fixes fdo#64837
* | Merge branch 'telepathy-glib-0.20' and update NEWSWill Thompson2013-04-142-3/+5
|\ \ | |/ | | | | | | Conflicts: NEWS
View Lorry Controller Status