diff options
| author | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2013-09-18 13:07:57 +0000 |
|---|---|---|
| committer | Simon McVittie <simon.mcvittie@collabora.co.uk> | 2013-11-18 13:12:39 +0000 |
| commit | 455929e7d6214250399ad5157ca33bd4e4ee38a0 (patch) | |
| tree | a8c1c1c4ca13c715439cc80db901bd76d4aa5c94 /src/mcd-debug.h | |
| parent | 712ddaf9b57fdc03e0c6b0b2c45ec04eaf135248 (diff) | |
| download | telepathy-mission-control-455929e7d6214250399ad5157ca33bd4e4ee38a0.tar.gz | |
Flag printf-ish functions with G_GNUC_PRINTF and fix resulting warningstelepathy-mission-control-5.14
In particular, mcd-account-manager-default could crash when migrating
an account, since it would dereference arbitrary stack contents
as a pointer-to-string.
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542
Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
[backported to 5.14 for Ubuntu]
Tested-by: Sebastien Bacher <seb128@ubuntu.com>
Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71539
Diffstat (limited to 'src/mcd-debug.h')
| -rw-r--r-- | src/mcd-debug.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/mcd-debug.h b/src/mcd-debug.h index 66fdafcc..53da2d01 100644 --- a/src/mcd-debug.h +++ b/src/mcd-debug.h @@ -59,7 +59,7 @@ static inline gint _mcd_debug_get_level (void) void mcd_debug_print_tree (gpointer obj); -void mcd_debug (const gchar *format, ...); +void mcd_debug (const gchar *format, ...) G_GNUC_PRINTF (1, 2); G_END_DECLS |