summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* Flag printf-ish functions with G_GNUC_PRINTF and fix resulting warningstelepathy-mission-control-5.14Simon McVittie2013-11-185-6/+7
| | | | | | | | | | | | In particular, mcd-account-manager-default could crash when migrating an account, since it would dereference arbitrary stack contents as a pointer-to-string. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> [backported to 5.14 for Ubuntu] Tested-by: Sebastien Bacher <seb128@ubuntu.com> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=71539
* resume developmentSimon McVittie2013-05-032-1/+6
|
* Prepare 5.14.1telepathy-mission-control-5.14.1Simon McVittie2013-05-032-3/+5
|
* NEWS for 5.14Simon McVittie2013-05-011-0/+5
|
* Only ignore passwords in gnome-keyring if Empathy has copied themSimon McVittie2013-05-011-5/+5
| | | | | | | | | | | | | | | | | When passwords are stored in the Parameters by MC and no SASLAuthentication handler is used, e.g. under Sugar, we currently save passwords into gnome-keyring, if enabled at compile time; so, we want to read them back out of gnome-keyring. This conflicts slightly with wanting to ignore passwords in gnome-keyring that are left over from an Empathy 3.0 schema migration that failed due to fd.o #42088. To avoid failure to authenticate/re-prompt if the password has been changed on the service side, ignore passwords that are going to be deleted; but to avoid breaking Sugar, don't ignore any other passwords we might find in gnome-keyring. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=59468
* NEWS for 5.14Simon McVittie2013-04-301-1/+7
|
* Fix the build with automake 1.13Nuno Araujo2013-04-301-1/+1
| | | | | | | | In Automake 1.13, the long-deprecated macro AM_CONFIG_HEADER (deprecated since 2002) has been removed in favour of AC_CONFIG_HEADERS. Reviewed-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=59605
* Merge fd.o #63119 from telepathy-glibSimon McVittie2013-04-041-0/+6
| | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=63119
* build: honor NOCONFIGURE in autogen.shCosimo Cecchi2012-11-161-10/+15
| | | | | | | Like telepathy-glib does already. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=57165 Reviewed-By: Simon McVittie <simon.mcvittie@collabora.co.uk>
* development versionSimon McVittie2012-10-032-1/+6
|
* fix Makefile syntaxtelepathy-mission-control-5.14.0Simon McVittie2012-10-031-1/+1
|
* exec-with-log.sh: add gdb wrapperSimon McVittie2012-10-033-0/+10
| | | | | | | Based on a patch from Jonny Lamb; changed to use ${abs_top_srcdir} to work out-of-tree, backtrace all threads, and put the gdb script in /tools. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* prepare 5.14.0Guillaume Desmottes2012-10-032-3/+30
|
* Don't warn on deprecated declarations, this is a stable branch.Simon McVittie2012-10-031-0/+1
| | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* Upload documentation to the 5.14.x locationGuillaume Desmottes2012-10-032-3/+3
| | | | To be reverted in the 5.15 branch.
* Don't check documentation completeness in this stable branchGuillaume Desmottes2012-10-031-10/+2
| | | | To be reverted in the 5.15 branch.
* Post-release version bumpSimon McVittie2012-09-202-1/+6
|
* Prepare version 5.13.2telepathy-mission-control-5.13.2Simon McVittie2012-09-202-3/+5
|
* NEWSSimon McVittie2012-09-201-0/+24
|
* Merge branch 'xdg-keyfile-35896'Simon McVittie2012-09-2016-119/+618
|\ | | | | | | | | | | | | Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896 Conflicts: src/mcd-account-manager-default.c
| * Update documentation of --with-accounts-dirSimon McVittie2012-09-071-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | It used to be where we kept accounts; now it's only the source for account migration into XDG_DATA_HOME. Keep its name the same, so that if a user or distribution is configuring with --with-accounts-dir="~/.mc-accounts" or something, the migration works as intended as long as they continue to do so. (We don't recommend doing so, though.) Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| * Default account backend: write accounts to XDG_DATA_HOME, with fallbackSimon McVittie2012-09-074-37/+120
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the user has ~/.mission-control/accounts/accounts.cfg we migrate from there to XDG_DATA_HOME/telepathy/mission-control/accounts.cfg, and if successful, delete the old name. If the user has XDG_DATA_DIRS/telepathy/mission-control/accounts.cfg (in a lower-priority path element than XDG_DATA_HOME), we use it, with copy-on-write into XDG_DATA_HOME. (Limitation: the account-store executable used in some tests only reads from XDG_DATA_HOME, and doesn't understand the XDG_DATA_DIRS and MC_ACCOUNT_DIR fallback.) Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| * Default account backend: include directory creation in _commitSimon McVittie2012-09-071-23/+26
| | | | | | | | | | | | | | Also check for errors - we can at least give a useful warning. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| * Default account backend: restructure to be able to look in multiple placesSimon McVittie2012-09-071-4/+45
| | | | | | | | | | | | | | | | This isolates all file-writing into _commit, and all file-reading into am_default_load_keyfile. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| * McdAccount: migrate avatars to a XDG pathSimon McVittie2012-09-075-49/+364
| | | | | | | | | | | | | | | | | | | | | | This is the easy part of XDGification: there is no plugin involvement or anything for avatars (yet!), it's just hard-coded. Changing the avatar location from a single directory to a search path results in some new corner cases, so test them. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| * mcd_ensure_directory: addSimon McVittie2012-09-072-0/+19
| | | | | | | | | | | | | | | | | | I keep calling g_mkdir_with_parents() and expecting it to return a boolean (it doesn't, it returns 0 or -1), so it seems worth wrapping it in something more sensible. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
| * Tests: distinguish between XDG cache/config/data home, and MC_ACCOUNT_DIRSimon McVittie2012-09-079-6/+46
| | | | | | | | | | | | | | We want to be sure that MC is using the right one in each situation. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=35896 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk>
* | Merge branch 'telepathy-mission-control-5.12' into masterSimon McVittie2012-09-203-2/+66
|\ \ | |/ |/| | | | | | | Conflicts: NEWS configure.ac
| * the obligatory version bumpSimon McVittie2012-09-202-1/+6
| |
| * Prepare version 5.12.3telepathy-mission-control-5.12.3Simon McVittie2012-09-202-4/+14
| |
| * Do not distribute mcp-signals-marshal.h, which is generated at build-timeSimon McVittie2012-09-201-1/+5
| | | | | | | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
| * Default accounts backend: finish password migrations that Empathy 3.0 startedSimon McVittie2012-09-201-0/+55
| | | | | | | | | | | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088 Bug-Debian: http://bugs.debian.org/687933 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
| * Make the gnome-keyring test work again, with modern gnome-keyringSimon McVittie2012-09-171-1/+10
| | | | | | | | | | | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=42088 Cherry-picked-from: c21e2b09bf4cdda6fb05d64f9198f6db7b776c76
* | servicetest: don't eavesdrop on method replies or errorsSimon McVittie2012-09-071-5/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Eavesdropping on method replies breaks libdbus if you call methods using the same connection. You can get into a situation like this: * Test calls a method on MC; say the serial number is 42 * At around the same time, MC calls a method on gnome-keyring and also uses serial number 42 * gnome-keyring replies, labelled "in reply to 42" * Test is eavesdropping, so it sees the reply going from gnome-keyring to MC * Test interprets the reply from gnome-keyring to MC as the reply it was expecting from MC, sees completely the wrong types, and becomes confused This seems unlikely - but because serial numbers are sequential and start from 1 for each connection (as opposed to starting from a random offset), two connections can quite easily happen to sync up. I saw it happen most recently in the gnome-keyring test. With the benefit of hindsight, I think I've seen this before: whenever the tests made an Introspect() call which returned a type other than 's', that was probably this bug. We never actually generated events for messages other than signals and method calls, so match those ones specifically, and don't eavesdrop on replies. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54495 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Jonny Lamb <jonny.lamb@collabora.co.uk>
* | Don't generate code for Account.I.Addressing, use telepathy-glib'sSimon McVittie2012-09-079-90/+8
| | | | | | | | | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
* | Be single-include-compliant when generating service bindingsSimon McVittie2012-09-071-1/+1
| | | | | | | | | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
* | Use G_VALUE_INIT instead of { 0 }Simon McVittie2012-09-0710-49/+57
| | | | | | | | | | | | | | | | We already depend on GLib 2.30, which is new enough. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
* | mcd_service_new: use tp_dbus_daemon_dup()Simon McVittie2012-09-071-4/+2
| | | | | | | | | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
* | mcd-dbusprop: remove support for filtering property setting through an ACLSimon McVittie2012-09-072-134/+0
| | | | | | | | | | | | | | | | | | | | This provided an asynchronous API for getting and setting properties, which nothing actually calls into, and nothing in MC supports setting properties asynchronously anyway. Into the bin it goes! Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
* | McdMaster: remove unused variable left over from old-style pluginsSimon McVittie2012-09-071-1/+0
| | | | | | | | | | | | Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
* | McdAccountManager: remove useless virtual methodSimon McVittie2012-09-072-22/+3
| | | | | | | | | | | | | | | | We no longer allow McdAccountManager or McdAccount to be subclassed. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
* | McdAccountManager: move initialization from init to constructedSimon McVittie2012-09-073-35/+16
| | | | | | | | | | | | | | | | | | | | This lets us use the construct properties, and in particular the TpDBusDaemon, which means we can make it a construct-time property on McdStorage. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk> Bug: https://bugs.freedesktop.org/show_bug.cgi?id=54633
* | Post-release version bumpSimon McVittie2012-09-062-1/+6
| |
* | prepare releasetelepathy-mission-control-5.13.1Simon McVittie2012-09-062-2/+4
| |
* | Merge branch 'telepathy-mission-control-5.12'Simon McVittie2012-09-065-10/+45
|\ \ | |/ | | | | | | | | Conflicts: NEWS configure.ac
| * tools/Makefile.am: be careful not to create empty files in the builddirSimon McVittie2012-09-061-5/+5
| | | | | | | | | | | | | | "make distcheck" in an already-out-of-tree build turns out not to work because of this. This corresponds to commit beb2d971 in telepathy-glib.
| * post-release version bumpSimon McVittie2012-09-062-1/+6
| |
| * Prepare releasetelepathy-mission-control-5.12.2Simon McVittie2012-09-062-3/+11
| |
| * Butterfly account migration: migrate the password too, if storedSimon McVittie2012-09-061-1/+11
| | | | | | | | | | | | | | | | Otherwise the upgrade from Debian 6 to 7 forgets MSN passwords, which is not the end of the world, but seems less nice than it could be. Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
| * Migrate from Butterfly to Haze even if Butterfly is no longer installedSimon McVittie2012-09-063-4/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Mission Control has a bug/design flaw/whatever in which it doesn't know the types of parameters without looking at the corresponding connection manager, which doesn't work if that connection manager has been uninstalled. This turns out to be bad for the upgrade from Debian 6 to Debian 7, which upgrades MC to a version that will perform the migration from Butterfly to Haze, but also uninstalls Butterfly... Since we know what the type of 'account' is, with a bit of refactoring we can tell McdAccount that we know it's a string, get its value anyway, and get on with our lives. Bug-Debian: http://bugs.debian.org/686835 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>