summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
...
* Don't warn on deprecated declarations, this is a stable branch.Simon McVittie2013-10-021-0/+1
|
* Don't check documentation completeness in this stable branchSimon McVittie2013-10-021-10/+2
|
* NEWS: adjust note about ServerAuthentication handlersSimon McVittie2013-10-021-2/+1
| | | | | | | | | | | | | | | | | rishi pointed out on IRC that ServerAuthentication still makes passwords available to eavesdroppers on the session bus (if LOGIN, PLAIN or X-TELEPATHY-PASSWORD are used). ServerAuthentication doesn't allow arbitrary applications to ask MC "what is the password for account X?", which is what I was thinking of. The session bus is not generally modelled to be a security boundary; if yours is, you will need to write a security policy, then ensure that that policy is applied. Telepathy components are not designed to be used unmodified on an untrusted session bus. (Starting points include turning off eavesdropping, applying a "default-deny" policy, preventing processes other than Mission Control from calling HandleChannels on your ServerAuthentication client, and preventing processes from subverting each other with ptrace.)
* avatar-refresh test: subsume avatar-persist, and test more situationsSimon McVittie2013-10-024-263/+350
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | We have some sort of combinatorial explosion going on here, and it seems best to test it in a somewhat systematic way: * is the protocol one where avatars persist on the server (Gabble) or not (Salut)? * if it's like Gabble, does it download our own avatar token before signalling CONNECTED (as I suspect Haze does), or on-demand after GetKnownAvatarTokens (as Gabble appears to)? * if it's like Gabble, is the server storing an avatar for us? * in either case, do we have an avatar stored locally, and has it previously been uploaded or not? In addition, the avatar-refresh and avatar-persist tests exercised migration from ~/.missioncontrol and a low-priority XDG_DATA_DIRS entry (respectively) to ~/.local/share. I didn't do that in a loop, because it isn't applicable in all cases and would lead to even more combinations - testing each case once should be enough. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69885 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> [cherry-picked from master commit d780671 plus the test part of 4f4ed24, adjusted for old constant naming and to replace unforbid_all() with unforbid_events() -smcv] Conflicts: tests/twisted/account-manager/avatar-persist.py tests/twisted/account-manager/avatar-refresh.py
* Implement Contacts properly on SimulatedConnection, and fix testsSimon McVittie2013-10-026-34/+112
| | | | | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69885 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> [Cherry-picked from commit 15510bd on master. -smcv] Conflicts: tests/twisted/constants.py tests/twisted/mctest.py
* McdAccount: go back to using GetKnownAvatarTokensSimon McVittie2013-10-021-21/+102
| | | | | | | | | | | | | | | | | | | | Sadly, contact attributes aren't enough to distinguish between "this protocol doesn't store avatars and you haven't re-sent your avatar since you last connected", "this protocol stores avatars but the CM hasn't checked for your current avatar yet", and "this protocol stores avatars, but there is no avatar on the server for you". GetKnownAvatarTokens specifically excludes the middle option (blocking on a server round-trip if it needs to), and uses "avatar token missing" for the first and "avatar token empty" for the last. Tested to work with the telepathy-glib 0.20 branch, and with the 0.22 branch when fdo#70010 is fixed. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69885 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> [This is a cherry-pick of commit 4f4ed24 from master, omitting the regression test change, to make sure the existing tests still pass -smcv]
* Update extension interfaces to their telepathy-spec 0.27.1 versionsSimon McVittie2013-09-204-26/+53
| | | | | | | No functional changes. The remaining interfaces (A.I.Conditions, CD.I.Messages) are still not in telepathy-spec at all. :-(
* Update CHECK_FOR_UNRELEASED to check the right filesSimon McVittie2013-09-201-1/+1
|
* Fix a wrong deprecation annotationSimon McVittie2013-09-201-1/+1
|
* Document the new test logging arrangementSimon McVittie2013-09-201-5/+9
| | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585
* connectivity test: make sure we've caught up on GDBus messagesSimon McVittie2013-09-202-0/+15
| | | | | | | | | | | Otherwise, the message from the FakeNetworkMonitor saying we've gone offline might not be received until after the message from the fake NM saying we've gone online - which would be a problem. There's no side-effect we can wait for here, so we just have to make sure the GDBus queue has been processed. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* connectivity_monitor_nm_state_change_cb: if NM says DISCONNECTED, believe itSimon McVittie2013-09-201-3/+7
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Log verbose test output and give it the same treatment as MC's logSimon McVittie2013-09-201-1/+5
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* run-test.sh.in: dump logfiles to stdout on failureSimon McVittie2013-09-201-0/+6
| | | | | | | | This is a lot of very spammy output, but the failures are basically undebuggable without it, so... Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* run-test.sh.in: now that we run under 'set -e', catch failuresSimon McVittie2013-09-201-2/+2
| | | | | | | | | If we just let with-session-bus.sh exit nonzero, the script aborts. We want to catch the nonzero exit status and do some more things before failing. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69585 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Nano versionSimon McVittie2013-09-192-1/+6
|
* 5.15.1 (5.16 rc1)telepathy-mission-control-5.15.1Simon McVittie2013-09-192-2/+25
|
* Put Autoconf, Automake, Libtool droppings in /build-auxSimon McVittie2013-09-192-0/+2
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* document MC_TEST_KEEP_TEMPSimon McVittie2013-09-191-1/+3
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* mcd_account_self_contact_upgraded_cb: don't crash on bad timingSimon McVittie2013-09-191-0/+5
| | | | | | | | If the account is disconnecting, we might get the callback for upgrading after we've already NULLed out self->priv->self_contact. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* tests: cd into the directory from which we were runSimon McVittie2013-09-193-1/+17
| | | | | | | | | dbus-daemon does a chdir("/") for activated services. We want to undo that, and put our logs (and core dumps, if any) in a more obvious place. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Tests: clean up all built sourcesSimon McVittie2013-09-191-1/+2
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* tests: write logs to MC_TEST_LOG_DIR, with latest log in `pwd`Simon McVittie2013-09-195-12/+23
| | | | | | | | | | This makes the logs' location rather more obvious. Not altering MC's working directory also means the core dump (if any) comes out in tests/twisted, which makes sense, instead of tests/twisted/tools, which doesn't. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* run-mc.sh.in: set DBUS_SYSTEM_BUS_ADDRESSSimon McVittie2013-09-193-3/+13
| | | | | | | | | This is used in the "installed" case, and this change is necessary to catch up with exec-with-log.sh.in in the "uninstalled" case. We want to use the fake NetworkManager, ConnMan etc., not the real ones. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Always use run-test.sh to run testsSimon McVittie2013-09-193-126/+151
| | | | | | | | | | | | | | | | | | There are three modes here: - make check: run tests in ${srcdir} against MC in ${builddir} - make installcheck: run tests in ${srcdir} against MC in ${DESTDIR}${prefix} - ${mctestsdir}/twisted/run-test.sh: run tests in ${mctestsdir} against MC in ${prefix} Also simplify the last of those cases, and avoid a potential symlink attack, by requiring that the current working directory for run-test.sh is a directory controlled by us. In practice we already required that, because with-session-bus.sh creates files in the current directory. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* installcheck-twisted: test the just-installed MC if using a DESTDIRSimon McVittie2013-09-191-1/+1
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Ignore /test-driver, installed by Automake 1.13Simon McVittie2013-09-191-0/+1
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Flag printf-ish functions with G_GNUC_PRINTF and fix resulting warningsSimon McVittie2013-09-196-7/+8
| | | | | | | | | In particular, mcd-account-manager-default could crash when migrating an account, since it would dereference arbitrary stack contents as a pointer-to-string. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69542 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* _mcd_channel_depart: use tp_channel_leave_async or tp_channel_close_asyncSimon McVittie2013-09-121-30/+22
| | | | | | | | | This avoids some deprecated APIs, and is considerably simpler. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391 Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55392 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
* Switch from tp_g_key_file_get_[u]int64 to g_key_file_get_[u]int64Simon McVittie2013-09-101-3/+3
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=69146 Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
* Service points: use tp_connection_dup_contact_by_id_asyncSimon McVittie2013-09-105-42/+39
| | | | | | | | | tp_connection_request_handles is deprecated. Ideally, we should drop this whole chunk of code, but it seems best to save that for Telepathy 1.0. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391 Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
* McdConnection: use tp_simple_client_factory_ensure_connectionSimon McVittie2013-09-104-36/+40
| | | | | | | | This means we need to pass the client factory through the McdManager from the McdMaster, so, do. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391 Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
* Deprecate mcp_dispatch_operation_leave_channelsSimon McVittie2013-09-103-0/+25
| | | | | | | It was designed for StreamedMedia, and is the wrong thing for Call. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55391 Reviewed-by: Xavier Claessens <xavier.claessens@collabora.co.uk>
* List Service and Hidden in create-time account propertiesSimon McVittie2013-09-103-1/+12
| | | | | | | Also test them. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=33127 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Remove further remnants of gnome-keyring supportSimon McVittie2013-09-107-171/+4
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32578 Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* NEWSSimon McVittie2013-09-051-0/+13
|
* drop unused variablesSimon McVittie2013-09-051-6/+0
|
* Remove gnome-keyring supportSimon McVittie2013-09-0512-870/+7
| | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=32578 Reviewed-by: Marco Barisione <marco.barisione@collabora.co.uk>
* Add a regression test for service-points (matched by identifier)Simon McVittie2013-09-053-54/+143
| | | | | | | | The side-effect they have within MC is that plugins aren't allowed to delay or reject channel requests; we ought to test that, really. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55773 Reviewed-by: Marco Barisione <marco.barisione@collabora.co.uk>
* McdConnection: build up our sets of emergency numbers over timeSimon McVittie2013-09-053-61/+44
| | | | | | | | | | | | | | | | | | To facilitate this, use nicer data structures. Most importantly, this means we don't critical whenever we get more than one distinct service point, as Jonny noticed while porting to Telepathy 1.0. It might slightly defeat the intention of the ServicePointsChanged signal, but in practice the list is probably never going to shrink, and if it does, it's probably wise to keep considering its old members to be an emergency number (the effect that that has is that plugins aren't allowed to influence channel requests). Also, don't leak the sets of emergency numbers when finalized. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=55773 Reviewed-by: Marco Barisione <marco.barisione@collabora.co.uk>
* Drop fake-network-monitor.h from SOURCESSimon McVittie2013-09-041-1/+0
| | | | It doesn't exist, and breaks distcheck.
* Add a regression test for a "no SimplePresence" special caseSimon McVittie2013-09-041-2/+10
| | | | | | | | | CurrentPresence should toggle between OFFLINE and UNSET if the account has no concept of presence. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68905 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Track presence via TpContact, not McdConnectionSimon McVittie2013-09-042-106/+29
| | | | | | | | | Now that McdAccount has a TpContact for the self-contact, this is really easy. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68905 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Add CONNECTIVITY_NONE, and make state transitions clearerSimon McVittie2013-09-041-16/+38
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68758 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* McdConnectivityMonitor: comment how McdInhibit worksSimon McVittie2013-09-041-0/+13
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68758 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Listen to systemd sleep/shutdown signals, and inhibit until disconnectedSimon McVittie2013-09-047-39/+345
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68758 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Remove unused signal McdAccount::connection-processSimon McVittie2013-09-043-19/+0
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* Remove the remains of McdTransportPluginSimon McVittie2013-09-0411-558/+5
| | | | | | Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* _mcd_master_account_replace_transport: inline into caller and simplifySimon McVittie2013-09-046-110/+13
| | | | | | | | | There's only one transport plugin, it only has one transport, and its state is basically boolean, so we can delete a lot of code. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
* mcd_master_connect_automatic_accounts: move to McdAccountManagerSimon McVittie2013-09-042-21/+7
| | | | | | | | Iterating over all accounts? Looks like a job for the account manager. Bug: https://bugs.freedesktop.org/show_bug.cgi?id=68712 Signed-off-by: Simon McVittie <simon.mcvittie@collabora.co.uk> Reviewed-by: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
View Lorry Controller Status