diff options
| author | Christopher Friedt <chrisfriedt@gmail.com> | 2022-10-01 09:01:45 -0400 |
|---|---|---|
| committer | Jens Geyer <Jens-G@users.noreply.github.com> | 2022-10-26 22:48:43 +0200 |
| commit | cea5559ecf458ccbb251594dba571f01bf0a2402 (patch) | |
| tree | 43398a54df5269000d93135eae91850806aaf4ca | |
| parent | 5ef174b5c1ab1ddd32f430ccacbad6d94e8dc452 (diff) | |
| download | thrift-cea5559ecf458ccbb251594dba571f01bf0a2402.tar.gz | |
lib: cpp: protocol: declare when methods override
This avoids compiler warnings about inconsistent use
of `override`.
Signed-off-by: Chris Friedt <cfriedt@meta.com>
| -rw-r--r-- | lib/cpp/src/thrift/protocol/TBinaryProtocol.h | 8 | ||||
| -rw-r--r-- | lib/cpp/src/thrift/protocol/TCompactProtocol.h | 8 | ||||
| -rw-r--r-- | lib/cpp/src/thrift/protocol/TJSONProtocol.h | 8 |
3 files changed, 12 insertions, 12 deletions
diff --git a/lib/cpp/src/thrift/protocol/TBinaryProtocol.h b/lib/cpp/src/thrift/protocol/TBinaryProtocol.h index b43144017..7b829c768 100644 --- a/lib/cpp/src/thrift/protocol/TBinaryProtocol.h +++ b/lib/cpp/src/thrift/protocol/TBinaryProtocol.h @@ -166,19 +166,19 @@ public: inline uint32_t readBinary(std::string& str); - int getMinSerializedSize(TType type); + int getMinSerializedSize(TType type) override; - void checkReadBytesAvailable(TSet& set) + void checkReadBytesAvailable(TSet& set) override { trans_->checkReadBytesAvailable(set.size_ * getMinSerializedSize(set.elemType_)); } - void checkReadBytesAvailable(TList& list) + void checkReadBytesAvailable(TList& list) override { trans_->checkReadBytesAvailable(list.size_ * getMinSerializedSize(list.elemType_)); } - void checkReadBytesAvailable(TMap& map) + void checkReadBytesAvailable(TMap& map) override { int elmSize = getMinSerializedSize(map.keyType_) + getMinSerializedSize(map.valueType_); trans_->checkReadBytesAvailable(map.size_ * elmSize); diff --git a/lib/cpp/src/thrift/protocol/TCompactProtocol.h b/lib/cpp/src/thrift/protocol/TCompactProtocol.h index 6f990b2d6..792a2d89e 100644 --- a/lib/cpp/src/thrift/protocol/TCompactProtocol.h +++ b/lib/cpp/src/thrift/protocol/TCompactProtocol.h @@ -140,19 +140,19 @@ public: uint32_t writeBinary(const std::string& str); - int getMinSerializedSize(TType type); + int getMinSerializedSize(TType type) override; - void checkReadBytesAvailable(TSet& set) + void checkReadBytesAvailable(TSet& set) override { trans_->checkReadBytesAvailable(set.size_ * getMinSerializedSize(set.elemType_)); } - void checkReadBytesAvailable(TList& list) + void checkReadBytesAvailable(TList& list) override { trans_->checkReadBytesAvailable(list.size_ * getMinSerializedSize(list.elemType_)); } - void checkReadBytesAvailable(TMap& map) + void checkReadBytesAvailable(TMap& map) override { int elmSize = getMinSerializedSize(map.keyType_) + getMinSerializedSize(map.valueType_); trans_->checkReadBytesAvailable(map.size_ * elmSize); diff --git a/lib/cpp/src/thrift/protocol/TJSONProtocol.h b/lib/cpp/src/thrift/protocol/TJSONProtocol.h index e775240ab..d01bdf801 100644 --- a/lib/cpp/src/thrift/protocol/TJSONProtocol.h +++ b/lib/cpp/src/thrift/protocol/TJSONProtocol.h @@ -245,19 +245,19 @@ public: uint32_t readBinary(std::string& str); - int getMinSerializedSize(TType type); + int getMinSerializedSize(TType type) override; - void checkReadBytesAvailable(TSet& set) + void checkReadBytesAvailable(TSet& set) override { trans_->checkReadBytesAvailable(set.size_ * getMinSerializedSize(set.elemType_)); } - void checkReadBytesAvailable(TList& list) + void checkReadBytesAvailable(TList& list) override { trans_->checkReadBytesAvailable(list.size_ * getMinSerializedSize(list.elemType_)); } - void checkReadBytesAvailable(TMap& map) + void checkReadBytesAvailable(TMap& map) override { int elmSize = getMinSerializedSize(map.keyType_) + getMinSerializedSize(map.valueType_); trans_->checkReadBytesAvailable(map.size_ * elmSize); |