diff options
| author | Dedipyaman Das <30053071+2DSharp@users.noreply.github.com> | 2020-09-27 02:29:23 +0530 |
|---|---|---|
| committer | Jens Geyer <jensg@apache.org> | 2020-09-27 12:04:43 +0200 |
| commit | 6fd830d69024435290ff0e92936b89ebc9603678 (patch) | |
| tree | ce270e0a6315593e4e83a0537d0a0ce09f63a2a0 | |
| parent | c553155af8330a54212eefefaf877b1725a449bc (diff) | |
| download | thrift-6fd830d69024435290ff0e92936b89ebc9603678.tar.gz | |
THRIFT-4942 Set PHP struct generated field values as private with getters and setters
Client: php
Patch: Das Dedipyaman
This closes #2245
Update field access for getters_setters flag. FFields are private if getters_setters are set, otherwise, public.
| -rw-r--r-- | compiler/cpp/src/thrift/generate/t_php_generator.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/compiler/cpp/src/thrift/generate/t_php_generator.cc b/compiler/cpp/src/thrift/generate/t_php_generator.cc index 10dc57032..96d5fbe67 100644 --- a/compiler/cpp/src/thrift/generate/t_php_generator.cc +++ b/compiler/cpp/src/thrift/generate/t_php_generator.cc @@ -939,7 +939,8 @@ void t_php_generator::generate_php_struct_definition(ostream& out, dval = render_const_value((*m_iter)->get_type(), (*m_iter)->get_value()); } generate_php_doc(out, *m_iter); - indent(out) << "public $" << (*m_iter)->get_name() << " = " << dval << ";" << endl; + string access = (getters_setters_) ? "private" : "public"; + indent(out) << access << " $" << (*m_iter)->get_name() << " = " << dval << ";" << endl; } out << endl; |