THRIFT-3927: Emit an error instead of throw an error in the async callback

Client: node
Patch: lifei

Because the data event of a connection is async handled, throw an exception can not tell the code the error. emit the error should be the correct way to handle the errors.

Closes #1087

2 files changed, 2 insertions, 2 deletions

diff --git a/lib/nodejs/lib/thrift/connection.js b/lib/nodejs/lib/thrift/connection.js
index 23cb01c79..575d51694 100644
--- a/lib/nodejs/lib/thrift/connection.js
+++ b/lib/nodejs/lib/thrift/connection.js
@@ -150,7 +150,7 @@ var Connection = exports.Connection = function(stream, options) {
         transport_with_data.rollbackPosition();
       }
       else {
-        throw e;
+        self.emit('error', e);
       }
     }
   }));
diff --git a/lib/nodejs/lib/thrift/http_connection.js b/lib/nodejs/lib/thrift/http_connection.js
index f3fcd7411..18bfadbc4 100644
--- a/lib/nodejs/lib/thrift/http_connection.js
+++ b/lib/nodejs/lib/thrift/http_connection.js
@@ -157,7 +157,7 @@ var HttpConnection = exports.HttpConnection = function(host, port, options) {
       if (e instanceof InputBufferUnderrunError) {
         transport_with_data.rollbackPosition();
       } else {
-        throw e;
+        self.emit('error', e);
       }
     }
   }