| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
| |
Patch: Vladimir Panivko
Client: php
This closes #2306
|
| |
|
|
|
|
|
|
|
|
|
| |
Client: go
Make a breaking change so that TClient.Call returns the response
meta, currently only contains headers but could be expanded in the
future, and make a compiler change to compiler generated clients to take
advantage of that and provide access to response metadata to users.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client: go
This fixes a bug introduced in
https://github.com/apache/thrift/pull/2296, that we mixed the preferred
proto id and the detected proto id, which was a bad idea.
This change separates them, so when we propagate TConfiguration, we only
change the preferred one, which will only be used for new connections,
and leave the detected one from existing connections untouched.
Also add a test for it.
|
|
|
|
|
|
|
|
| |
Client: go
Having it under a subdirectory has some unexpected consequences, so
remove it for now. Another PR will be open up later to add it back to
the root directory.
|
|
|
|
|
|
|
|
|
| |
Client: go
- Update Dockerfiles used by travis
- Add go.mod file
- Modify error handling code to take advantage of errors package updates
in go1.13
|
|
|
|
|
|
|
| |
Client: go
As a follow up to https://github.com/apache/thrift/pull/2298, make the
error returned by PrependError unwrap-able in certain cases.
|
|
|
|
| |
recognized as MSVC (because it does not handle -Wall too well)
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client: go
Add TExceptionType enum type, and add
TExceptionType() TExceptionType
function to TException definition.
Also make TProtocolException unwrap-able.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client: go
Define TConfiguration following the spec, and also move the following
configurations scattered around different TTransport/TProtocol into it:
- connect and socket timeouts for TSocket and TSSLSocket
- tls config for TSSLSocket
- max frame size for TFramedTransport
- strict read and strict write for TBinaryProtocol
- proto id for THeaderTransport
Also add TConfiguration support for the following and their factories:
- THeaderTransport and THeaderProtocol
- TBinaryProtocol
- TCompactProtocol
- TFramedTransport
- TSocket
- TSSLSocket
Also define TConfigurationSetter interface for easier TConfiguration
propagation between wrapped TTransports/TProtocols , and add
implementations to the following for propagation
(they don't use anything from TConfiguration themselves):
- StreamTransport
- TBufferedTransport
- TDebugProtocol
- TJSONProtocol
- TSimpleJSONProtocol
- TZlibTransport
TConfigurationSetter are not implemented by the factories of the
"propagation only" TTransports/TProtocols, if they have a factory. For
those use cases, TTransportFactoryConf and TProtocolFactoryConf are
provided to wrap a factory with the ability to propagate TConfiguration.
Also add simple sanity check for TBinaryProtocol and TCompactProtocol's
ReadString and ReadBinary functions. Currently it only report error if
the header length is larger than MaxMessageSize configured in
TConfiguration, for simplicity.
|
| |
|
|
|
|
|
| |
Client: py
This allows clients to choose which subprotocol (TBinary/TCompact) to frame with headers. The server will already accept either protocol and reply correctly.
|
|
|
|
|
|
|
| |
Client: lua
Patch: Jeffrey Han
This closes #2297
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client: go
In TBinaryProtocol.ReadString, TBinaryProtocol.ReadBinary,
TCompactProtocol.ReadString, and TCompactProtocol.ReadBinary, use
safeReadBytes to prevent from large allocation on malformed sizes.
$ go test -bench=SafeReadBytes -benchmem
BenchmarkSafeReadBytes/normal-12 625057 1789 ns/op 2176 B/op 5 allocs/op
BenchmarkSafeReadBytes/max-askedSize-12 545271 2236 ns/op 14464 B/op 7 allocs/op
PASS
|
|
|
|
|
|
|
|
|
|
|
| |
Client: go
The fix in https://github.com/apache/thrift/pull/2293 doesn't work for
go1.10.8 due to the possibility of data races. This exposes a bigger,
underlying issue regarding the ownership of the request buffer in
THttpClient between THttpClient itself and the http request it creates.
Instead of reset and reuse the same buffer, always give up the ownership
of it and create a new buffer after each Flush call.
|
| |
|
|
|
|
|
|
|
| |
Client: lua
Patch: Jeffrey Han
This closes #2243
|
|
|
|
|
|
|
| |
THttpClient did not reset its internal buffer when HTTP client returned
an error, leaving the whole or partially read message in the buffer.
Now we reset the buffer in defer.
Client: go
|
|
|
|
|
|
|
| |
Client: Rust
Patch: Dirkjan Ochtman
This closes #2291
|
|
|
|
|
| |
Client: netstd
Patch: Jens Geyer
|
|
|
|
|
|
|
|
|
| |
Client: cpp
Patch: Riccardo Ghetta
This closes #2260
Signed-off-by: rglarix <rglarix@users.noreply.github.com>
|
| |
|
|
|
|
|
|
|
| |
Client: netstd
Patch: Jens Geyer
This closes #2289
|
|
|
|
|
|
|
| |
Client: erl
Patch: Sergey Yelin
This closes #2290
|
|
|
|
|
|
|
| |
Client: cpp
Patch: Mario Emmenlauer
This closes #2281
|
|
|
|
|
| |
Client: netstd
Patch: Jens Geyer
|
| |
|
|
|
|
| |
Console.Error as before
|
|
|
|
|
| |
Client: netstd
Patch: Jens Geyer
|
|
|
|
|
|
|
| |
Client: netstd
Patch: Konstantin Pozdniakov & Jens Geyer
This closes #2284
|
| |
|
| |
|
| |
|
| |
|
| |
|
|
|
|
|
|
|
| |
Client: Java
Patch: David Mollitor
This closes #2254
|
|
|
|
|
|
|
| |
Patch: Mario Emmenlauer
Client: netstd
This closes #2282
|
|\
| |
| | |
THRIFT-5306: Rust code and generated code no longer has clippy warnings (Rust 1.40)
|
| |
| |
| |
| |
| |
| |
| |
| | |
(Rust 1.40)
Client: rs
NOTE: Also properly update the min/max supported Rust versions
|
| |
| |
| |
| |
| |
| | |
Patch: Pooja Chandak
This closes #2271
|
| |
| |
| |
| |
| |
| |
| | |
Client: py
Patch: stiga-huang
This closes #2269
|
| |
| |
| |
| |
| |
| | |
Patch: wangliming07 <wangliming07@58.com>
This closes #2268
|
| | |
|
| | |
|
|/
|
|
|
|
|
| |
is reached
Client: Delphi
Patch: Jens Geyer
|
|
|
|
|
|
|
|
|
| |
This adds an Automatic-Module-Name entry to the Thrift jar manifest
in order to provide Thrift with a stable module name when used in a
JPMS modular context. The name chosen here is "org.apache.thrift",
which matches the symbolic name used for OSGi.
See: http://branchandbound.net/blog/java/2017/12/automatic-module-name/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This also comes from the discussion of
https://github.com/apache/thrift/pull/1992#issuecomment-705903922.
I think TDebugProtocol is a better fit for this feature than creating a
new TProtocol implementation.
The DuplicateTo field is not added to TDebugProtocolFactory because I
don't think it makes sense from the factory setup. In vast majority
cases users would need direct access to the underlying TMemoryBuffer to
make it useful, which is easier this way than an additional
TTransportFactory plus TProtocolFactory to make TDebugProtocolFactory
way too complicated.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Client: go
In go library's TSimpleJSONProtocol and TJSONProtocol implementations,
we use slices as stacks for context info, but didn't do proper boundary
check when peeking/popping, result in it might panic with using -1 as
slice index in certain cases of calling Write*End without matching
Write*Begin before.
Refactor the code to properly implement the stack, and return a
TProtocolException instead on those cases.
Also add unit tests for all protocols. The unit tests shown that
TCompactProtocol.[Read|Write]StructEnd would also panic with unmatched
Begin calls, so fix them as well.
|