summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJoe Hershberger <joe.hershberger@ni.com>2012-09-18 10:01:32 +0000
committerJoe Hershberger <joe.hershberger@ni.com>2012-09-24 13:55:44 -0500
commit8a0eccb1056b313b45ab62e3aac400f339aa71b4 (patch)
treef1392d5d87080b8c8059504544e9ae2ad3521aa6
parente827fec2b24d4412eabed3cf0080a08a0a7d148c (diff)
downloadu-boot-8a0eccb1056b313b45ab62e3aac400f339aa71b4.tar.gz
net: Filter incoming netconsole packets by IP
Check the incoming packets' source IP address... if ncip isn't set to a broadcast address, only listen to the client at ncip. Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
-rw-r--r--drivers/net/netconsole.c8
-rw-r--r--include/net.h3
-rw-r--r--net/net.c1
3 files changed, 9 insertions, 3 deletions
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
index 63ce73c818..dd7032af56 100644
--- a/drivers/net/netconsole.c
+++ b/drivers/net/netconsole.c
@@ -147,13 +147,17 @@ void NcStart(void)
}
}
-int nc_input_packet(uchar *pkt, unsigned dest, unsigned src, unsigned len)
+int nc_input_packet(uchar *pkt, IPaddr_t src_ip, unsigned dest_port,
+ unsigned src_port, unsigned len)
{
int end, chunk;
- if (dest != nc_in_port || !len)
+ if (dest_port != nc_in_port || !len)
return 0; /* not for us */
+ if (src_ip != nc_ip && !is_broadcast(nc_ip))
+ return 0; /* not from our client */
+
debug_cond(DEBUG_DEV_PKT, "input: \"%*.*s\"\n", len, len, pkt);
if (input_size == sizeof(input_buffer))
diff --git a/include/net.h b/include/net.h
index e193b7b60b..35393366d3 100644
--- a/include/net.h
+++ b/include/net.h
@@ -549,7 +549,8 @@ extern void NetReceive(uchar *, int);
#ifdef CONFIG_NETCONSOLE
void NcStart(void);
-int nc_input_packet(uchar *pkt, unsigned dest, unsigned src, unsigned len);
+int nc_input_packet(uchar *pkt, IPaddr_t src_ip, unsigned dest_port,
+ unsigned src_port, unsigned len);
#endif
static inline __attribute__((always_inline)) int eth_is_on_demand_init(void)
diff --git a/net/net.c b/net/net.c
index a89946ebe0..809fb14c79 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1161,6 +1161,7 @@ NetReceive(uchar *inpkt, int len)
#ifdef CONFIG_NETCONSOLE
nc_input_packet((uchar *)ip + IP_UDP_HDR_SIZE,
+ ntohl(ip->ip_src),
ntohs(ip->udp_dst),
ntohs(ip->udp_src),
ntohs(ip->udp_len) - UDP_HDR_SIZE);