diff options
| author | Simon Glass <sjg@chromium.org> | 2017-06-07 10:28:47 -0600 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2017-06-12 08:38:12 -0400 |
| commit | 22929bec528f42c1a7fbcd76adeea8daed9ba55c (patch) | |
| tree | 225d5c0349f1e80d86b2058c09a6a0795132cb72 | |
| parent | baa7d345fb2a7aaee31af6d77f2a790e89864af6 (diff) | |
| download | u-boot-22929bec528f42c1a7fbcd76adeea8daed9ba55c.tar.gz | |
rkcommon.c: Drop pointless assignment
Assigning a variable to itself is not necessary. Drop this and also add a
check for malloc() failure.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Coverity (CID: 161418)
Fixes: 111bcc4 (rockchip: mkimage: pad the header to 8-bytes (using a 'nop') for RK3399)
| -rw-r--r-- | tools/rkcommon.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/rkcommon.c b/tools/rkcommon.c index fd95abc79a..a583c0caa0 100644 --- a/tools/rkcommon.c +++ b/tools/rkcommon.c @@ -380,8 +380,9 @@ int rkcommon_vrec_header(struct image_tool_params *params, /* Allocate, clear and install the header */ tparams->hdr = malloc(tparams->header_size); + if (!tparams->hdr) + return -ENOMEM; memset(tparams->hdr, 0, tparams->header_size); - tparams->header_size = tparams->header_size; /* * If someone passed in 0 for the alignment, we'd better handle |